Skip to content

Conversation

@peterdschwartz
Copy link
Contributor

@peterdschwartz peterdschwartz commented Nov 25, 2025

Description:
Plant functional type definition and physiological changes for improved arctic vegetation representation. (1) flexible Arctic PFT definitions, currently 12 PFTs, with lifeforms of non-vascular, woody, graminoid, or cropped, plus properties such as climate-zone, N-fixer, and needle-leaf type; (2) allow dormancy of root respiration during winter period; (3) add 'Rhizome' as coarse root for non-woody PFT; (4) Allow evergreen PFT to have storage pool as well; and (4) Allow N fixation parameterized for individual PFT.

[non-BFB] due to round-off in balance terms.

fmyuan and others added 14 commits November 24, 2025 20:33
…machine with limited input data, but NOT YET fully work. Two tests are actually similary as 'elm_usrdat' test, but with 42_FLUXNETSITES and a few physiology parameters, based on Sulman et al. (2021).One of them is a short run to test codes, while another is a long run for bug-fixing heavy winter snow caused issue in arctic pft phenology. Those tests won't change simulation results until new codes and parameters are pull in.
…y PFT. Now column N fixation is calculated as a weighted average over PFTs.
… snow winter, snow-melt may last past the summer solstice. This likely causes no PFT onset stage even when a short non-snow season occurs.

Add a flag for switching plant growth onset gdd summation end option in phenology. The switch is for extending onset stage up to start of offset in Fall, rather than to summer solstice by default.
Allow 2 tests function with new parameter file.
…me round-off differences, which may cause one test failure (although very tiny difference).
…t al. (2021), to be included in ELM land developer test suites.
@peterdschwartz peterdschwartz marked this pull request as draft November 25, 2025 15:49
@peterdschwartz
Copy link
Contributor Author

peterdschwartz commented Nov 25, 2025

  • Some forcing files still need to be added to data server
  • Refactor duplicated code into functions
  • clean-up comments

@peterdschwartz
Copy link
Contributor Author

@fmyuan I think it'd be best if you or someone from the NGEE-Arctic team wrote the PR description.

@fmyuan
Copy link
Contributor

fmyuan commented Nov 26, 2025

@fmyuan I think it'd be best if you or someone from the NGEE-Arctic team wrote the PR description.

I will. And I believe Ben already put something into E3SM repo/archive, but let me check.

@fmyuan fmyuan marked this pull request as ready for review December 1, 2025 20:25
Copy link
Contributor

@fmyuan fmyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and pass land developer tests on cades-baseline machine.

@fmyuan
Copy link
Contributor

fmyuan commented Dec 1, 2025

IM4 new feature overview.pdf
I attached Ben Sulman's overview on the features included in this PR.

@rljacob rljacob added the ELM land model label Dec 2, 2025
@peterdschwartz peterdschwartz added the non-BFB PR makes roundoff changes to answers. label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ELM land model non-BFB PR makes roundoff changes to answers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants