Open
Conversation
Initial commit for testing on AARCH64. Issue #7842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
instr_get_isa_feature()in AARCH64 where instructions likebcondwere incorrectly reported with an
<invalid>ISA feature in the opcode_mix tool.The root cause was that
instr_get_isa_feature()instantiated adecode_info_tstruct without initialization, leaving the
check_reachableflag containingindeterminate stack data.
When this flag happened to be true, the encoding walk of
instr_get_isa_feature()enforced reachability checks on PC-relative operands.
Depending on how
instr_get_isa_feature()is used,pcis not necessarily theinstruction's actual pc, it can be an unrelated address like a buffer, so disabling
the reachability check is necessary.
Adds a unit test that would trigger returning
<invalid>ISA feature if thereachability check were to be enabled.
Issue #7842