Skip to content

i#7823: Look for MEMPROT_EXEC when looking for the executable #7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palmer-dabbelt wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

i#7823: Look for MEMPROT_EXEC when looking for the executable #7824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/unix/os.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10245,7 +10245,7 @@ os_walk_address_space(memquery_iter_t *iter, bool add_modules)
/* we already added the whole image region when we hit the first map for it */
image = true;
DODEBUG({ map_type = "ELF SO"; });
} else if (TEST(MEMPROT_READ, iter->prot) &&
} else if (TEST(MEMPROT_READ | MEMPROT_EXEC, iter->prot) &&
Copy link
Copy Markdown
Contributor

@abhinav92003 abhinav92003 Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the consensus in the other comment thread was to add this MEMPROT_EXEC check to L10288 (the line #s have changed now it seems; maybe because the force-push also updated the branch baseline?). Like I said, by doing that, we can avoid making any assumption about the anon region case (see L10289).

Does this solve your crash?

module_is_header(iter->vm_start, size)) {
DEBUG_DECLARE(size_t image_size = size;)
app_pc mod_base, mod_first_end, mod_max_end;
Expand Down
Loading