Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs a version sync update to 26.1.15 and implements significant refactoring of the SML (Speech Markup Language) tag handling system, along with various code quality improvements and bug fixes.
Changes:
- Version bump from 25.12.33 to 26.1.15 across all configuration files
- Major refactoring of SML tag processing: replaced dict-based token/match structure with a unified regex pattern (
SML_TAG_PATTERN) and helper function (sml_token) - Code quality improvements including quote style standardization, removal of trailing whitespace, duplicate code elimination, and improved variable naming
- Changed default Docker device from 'cpu' to 'cu128' for GPU acceleration
- Removed Dutch ('nl') language support from TACOTRON2 engine
- Updated urllib3 dependency to 2.6.3 (non-existent version)
- Refactored multiprocessing progress queue management
- Added worker directories for chapter and sentence processing
- Function signature reordering for consistency (get_chapters, combine_audio_sentences)
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Version update to 26.1.15 |
| podman-compose.yml | Version update and default device change to cu128 |
| docker-compose.yml | Version update and default device change to cu128 |
| Dockerfile | Version update to 26.1.15 |
| VERSION.txt | Version update to 26.1.15 |
| README.md | Updated feature list, added SML tags documentation, fixed typo |
| lib/core.py | Major SML refactoring, function signature changes, duplicate import issues, function ordering problems |
| lib/conf_models.py | Replaced TTS_SML dict structure with simplified paired flags, added SML_TAG_PATTERN regex |
| lib/init.py | Export SML_TAG_PATTERN and renamed default_sml_pattern |
| lib/gradio.py | Quote style changes from double to single quotes |
| lib/classes/tts_engines/*.py | Updated to use new SML pattern and removed alphanumeric filtering logic |
| lib/classes/tts_engines/common/utils.py | Refactored _convert_sml to use new pattern matching, removed duplicate code, disabled bfloat16 |
| lib/classes/tts_engines/common/headers.py | Updated imports for renamed SML pattern |
| lib/classes/tts_engines/presets/tacotron_presets.py | Removed Dutch ('nl') language support |
| components/audiocraft/requirements.txt | Updated urllib3 to non-existent version 2.6.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.