Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/semantic_release/commit_parser/emoji.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,12 @@ class EmojiParserOptions(ParserOptions):
)
"""Commit-type prefixes that should result in a patch release bump."""

other_allowed_tags: Tuple[str, ...] = (":memo:", ":checkmark:")
other_allowed_tags: Tuple[str, ...] = (
":checkmark:",
":construction_worker:",
":memo:",
":recycle:",
)
"""Commit-type prefixes that are allowed but do not result in a version bump."""

allowed_tags: Tuple[str, ...] = (
Expand Down
2 changes: 1 addition & 1 deletion tests/const.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class RepoActionStep(str, Enum):
)
EMOJI_COMMITS_MINOR = (
*EMOJI_COMMITS_PATCH,
":sparkles::pencil: docs for something special\n",
":sparkles::memo: docs for something special\n",
# Emoji in description should not be used to evaluate change type
":sparkles: last minute rush order\n\nGood thing we're 10x developers :boom:\n",
)
Expand Down
18 changes: 13 additions & 5 deletions tests/unit/semantic_release/commit_parser/test_emoji.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,20 +42,28 @@
[":bug: Fixing a bug", "The bug is finally gone!"],
[],
),
# No release
# No release with specified emoji
(
":pencil: Documentation changes",
":memo: Documentation changes",
LevelBump.NO_RELEASE,
":memo:",
[":memo: Documentation changes"],
[],
),
# No release with random emoji
(
":construction: Work in progress",
LevelBump.NO_RELEASE,
"Other",
[":pencil: Documentation changes"],
[":construction: Work in progress"],
[],
),
# Multiple emojis
(
":sparkles::pencil: Add a feature and document it",
":sparkles::memo: Add a feature and document it",
LevelBump.MINOR,
":sparkles:",
[":sparkles::pencil: Add a feature and document it"],
[":sparkles::memo: Add a feature and document it"],
[],
),
# Emoji in description
Expand Down
Loading