Skip to content

Fix finalStandings() return type for round-robin stages #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Drarig29 merged 1 commit into from
Feb 25, 2026
Merged

Fix finalStandings() return type for round-robin stages #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/get.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Stage, Group, Round, Match, MatchGame, Participant, Status, Id, RankingItem } from 'brackets-model';
import { Stage, Group, Round, Match, MatchGame, Participant, Status, Id } from 'brackets-model';
import { Database, FinalStandingsItem, ParticipantSlot, type RoundRobinFinalStandingsItem, type RoundRobinFinalStandingsOptions } from './types';
import { BaseGetter } from './base/getter';
import * as helpers from './helpers';
Expand Down Expand Up @@ -217,9 +217,9 @@ export class Get extends BaseGetter {
* @param stageId ID of the stage.
* @param rankingFormula The formula to compute the points for the ranking.
*/
public async finalStandings(stageId: Id, roundRobinOptions: RoundRobinFinalStandingsOptions): Promise<RankingItem[]>;
public async finalStandings(stageId: Id, roundRobinOptions: RoundRobinFinalStandingsOptions): Promise<RoundRobinFinalStandingsItem[]>;
// eslint-disable-next-line jsdoc/require-jsdoc
public async finalStandings(stageId: Id, roundRobinOptions?: RoundRobinFinalStandingsOptions): Promise<FinalStandingsItem[] | RankingItem[]> {
public async finalStandings(stageId: Id, roundRobinOptions?: RoundRobinFinalStandingsOptions): Promise<FinalStandingsItem[] | RoundRobinFinalStandingsItem[]> {
const stage = await this.storage.select('stage', stageId);
if (!stage) throw Error('Stage not found.');

Expand Down