Skip to content

fix(proxy): scope model availability by account - #302

Open
Draculabo wants to merge 9 commits into
mainfrom
codex/proxy-scope-model-availability
Open

fix(proxy): scope model availability by account#302
Draculabo wants to merge 9 commits into
mainfrom
codex/proxy-scope-model-availability

Conversation

@Draculabo

Copy link
Copy Markdown
Owner

Summary

  • keep image-model 404 failures scoped to the failing account
  • preserve sibling image availability and non-image capability failures
  • update the BaseProxyService regression test for the current shared retry-policy dependency

Validation

  • 22 focused proxy tests
  • TypeScript type-check
  • targeted ESLint

@codereviewbot-ai

codereviewbot-ai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Summary of Changes

  • Image Model 404 Penalty Isolation: Updated BaseProxyService.applyUpstreamPenalty to skip calling markModelUnrequestable for image models (-image), ensuring image 404 responses are scoped per-account rather than disabling the model across all accounts.
  • Model Availability Clearance Refinement: Refactored ModelAvailabilityService.clearModel to remove side-effect clearing of sibling image models when clearing a specific model's availability status.
  • Test Coverage: Added comprehensive unit test coverage in base-proxy-model-not-found-scope.test.ts and updated proxy-model-availability-store.test.ts.

LGTM!


🤖 Reviewed by codereviewbot.ai - Catch bugs before your team does.

@codereviewbot-ai

Copy link
Copy Markdown

🤖 Review skipped: Repository Owner rate limit exceeded. Free accounts are limited to 3 reviews per 4 hours across all repositories. Upgrade to a paid plan for unlimited reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant