Remove dependency on hash extension on 8.6#79
Merged
Conversation
47 tasks
remicollet
force-pushed
the
issue-php86a2
branch
from
July 21, 2026 09:42
31cd3a5 to
a6f1ec0
Compare
Collaborator
|
Uhh @remicollet I just completely didn't notice this PR, and I fixed the same issues just now (#80) 😢 I'm sorry very much, and thanks for the help! |
kocsismate
reviewed
Jul 22, 2026
| /* Get the parameters for this call */ | ||
| raw_output = 0; | ||
| if (zend_parse_parameters_throw( | ||
| if (zend_parse_parameters( |
Collaborator
There was a problem hiding this comment.
This would be a slight change in the behavior because it wouldn't throw on PHP 7.x. That's why I used new ZPP for PHP 8.x, and stayed with zend_parse_parameters_throw() for PHP 7.x. In a few years, we can get rid of the old ZPP, I guess it will be time to require PHP 8.0+ then.
The ZPP migration also uncovered a few type issues which I also fixed/suppressed.
kocsismate
reviewed
Jul 22, 2026
remicollet
force-pushed
the
issue-php86a2
branch
from
July 22, 2026 09:07
a6f1ec0 to
4364298
Compare
Contributor
Author
|
Rebased and amended |
Contributor
Author
|
Notice, checked no ext/hash symbols are used by |
kocsismate
approved these changes
Jul 22, 2026
kocsismate
left a comment
Collaborator
There was a problem hiding this comment.
Thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From UPGRADING.INTERNALS
And remove dependency on hash extension