add warning for mismatching mate scores#1001
Open
robertnurnberg wants to merge 1 commit intoDisservin:masterfrom
Open
add warning for mismatching mate scores#1001robertnurnberg wants to merge 1 commit intoDisservin:masterfrom
robertnurnberg wants to merge 1 commit intoDisservin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR emits a warning if both engines claim to have found a proven win, and same for a proven loss. Of course, this can only happen if one of the two engines is buggy, or if the first engine sent a
bestmovethat does not correspond to the (winning) mate score.I prefixed the warning line that contains both info lines with
Infos;. Let me know if this should be changed.Example: