Fix extra initial newline in PGN writing#1000
Merged
Disservin merged 1 commit intoDisservin:masterfrom Apr 5, 2026
Merged
Conversation
Owner
|
i'll bump the version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the initial line is > 80 characters, then a leading newline is added, leading to multiple new lines between the headers and body of the PGN, which breaks the spec., and breaks python-chess at least. PR fixes it.
This is technically going to be a breaking change for OpenBench. I don't have a great mechanism to force update other than the version value. So if its immaterial to you, bumping the version to 1.8.1 would help me. If not, then I'll go and get some versioning more granular.