feat: convert output to framework results#2
Open
abdalazizmoh wants to merge 2 commits intoDevOpsHiveHQ:mainfrom
Open
feat: convert output to framework results#2abdalazizmoh wants to merge 2 commits intoDevOpsHiveHQ:mainfrom
abdalazizmoh wants to merge 2 commits intoDevOpsHiveHQ:mainfrom
Conversation
Collaborator
|
@abdalazizmoh Your code looks good to me, but there is something odd when it's used in Kustomize (it could be a bug in Kustomize itself). As I understand, if the plugin returned a non-empty ".results" and one of the items has a severity error, then Kustomize should exit with non-zero. 🤔 Maybe we need to verify that and understand what is the expected behavior in Kustomize. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
This PR is for converting Json error output to Yaml format to be more readable
Build the tool
go build -o 'dist/kubeconformvalidator' .Testing using /example directory :
cat example/krm-function-input.yaml| ./dist/kubeconformvalidatorThe output display in
framework.Resultsformat:Thanks