Skip to content

Modernize rgb() function with DefaultFunction.builder() #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dev-Xeiji wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Modernize rgb() function with DefaultFunction.builder() #1

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9eeeedb
Update DefaultFunctions.java
Dev-Xeiji May 1, 2026
0bba1f4
Update src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java
Dev-Xeiji May 1, 2026
829e024
Update src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java
Dev-Xeiji May 1, 2026
58a2887
Merge branch 'dev/patch' into Modernize-rgb()-function-with-DefaultFu…
Efnilite May 1, 2026
b41afd3
Merge branch 'dev/patch' into Modernize-rgb()-function-with-DefaultFu…
APickledWalrus May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 15 additions & 18 deletions src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,28 +602,25 @@ public Long[] executeSimple(Object[][] params) {
}.description("Calculates the total amount of experience needed to achieve given level from scratch in Minecraft.")
.since("2.2-dev32"));

Functions.registerFunction(new SimpleJavaFunction<Color>("rgb", new Parameter[] {
new Parameter<>("red", DefaultClasses.LONG, true, null),
new Parameter<>("green", DefaultClasses.LONG, true, null),
new Parameter<>("blue", DefaultClasses.LONG, true, null),
new Parameter<>("alpha", DefaultClasses.LONG, true, new SimpleLiteral<>(255L,true))
}, DefaultClasses.COLOR, true) {
@Override
public ColorRGB[] executeSimple(Object[][] params) {
Long red = (Long) params[0][0];
Long green = (Long) params[1][0];
Long blue = (Long) params[2][0];
Long alpha = (Long) params[3][0];

return CollectionUtils.array(ColorRGB.fromRGBA(red.intValue(), green.intValue(), blue.intValue(), alpha.intValue()));
}
}).description("Returns a RGB color from the given red, green and blue parameters. Alpha values can be added optionally, " +
"but these only take affect in certain situations, like text display backgrounds.")
Functions.register(DefaultFunction.builder(skript, "rgb", Color.class)
.description("""
Returns a RGB color from the given red, green and blue parameters.
Alpha values can be added optionally but these only take affect in certain situations, like text display backgrounds.""")
.examples(
"dye player's leggings rgb(120, 30, 45)",
"set the colour of a text display to rgb(10, 50, 100, 50)"
)
.since("2.5, 2.10 (alpha)");
.since("2.5, 2.10 (alpha)")
.parameter("red", Long.class, Modifier.ranged(0, 255))
.parameter("green", Long.class, Modifier.ranged(0, 255))
.parameter("blue", Long.class, Modifier.ranged(0, 255))
.parameter("alpha", Long.class, Modifier.ranged(0, 255), Modifier.OPTIONAL)
.build(args -> ColorRGB.fromRGBA(
args.<Long>get("red").intValue(),
args.<Long>get("green").intValue(),
args.<Long>get("blue").intValue(),
args.getOrDefault("alpha", 255L).intValue()
)));

Functions.register(DefaultFunction.builder(skript, "player", Player.class)
.description(
Expand Down