docs: narrow Optional radiated_noise in autocomplete example#15
Merged
Conversation
The shipped scratch file triggered a Pylance reportOptionalMemberAccess warning because radiated_noise is Optional on the schema. Add an assert to narrow it (the same idiom the pipeline uses, and an instructive one), so learners see clean, fully-typed access. Sync the README walkthrough. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AHAkhfmfcCdWTHZuvRcJNF
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
examples/explore_platform.pyscratch file (added for Adventure 2) triggered a PylancereportOptionalMemberAccesswarning:radiated_noiseisOptionalon the generated model (the schema allows it to be absent), so.bandis flagged as a possibleNoneaccess. The pipeline's verification gates guarantee it's populated, but the type checker can't know that statically — so the shipped learning file showed a red squiggle.Changes
assert platform.radiated_noise is not Noneafter the build — the sameOptional-narrowing idiom the pipeline code uses (cli.py). After it,.bandis a clean, fully-typed access, and it's an instructive moment about working withOptional.# platform.radiated_noise.and sync the README walkthrough (mentions tryingplatform.for top-level attributes too).Verification
python examples/explore_platform.pyruns and prints the platform type and first band centre frequency.mypyreports no issues on the file.🤖 Generated with Claude Code
Generated by Claude Code