fix: Docker pull hanging on Windows - #76
Merged
Merged
Conversation
rboni-dk
force-pushed
the
fix-pull-hanging
branch
from
September 29, 2025 15:45
b5b39c0 to
20a7659
Compare
Coverage Report •
|
aarthy-dk
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IO buffers are smaller on Windows and python's implementation of
Popen.communicate()does different things on Windows too (uses thread). Not usingcommunicateis the most likely cause for the process to hang on that OS, so this PR is refactoring how we read from the command output streams to usecommunicate.