Skip to content

fix: Docker pull hanging on Windows - #76

Merged
rboni-dk merged 1 commit into
mainfrom
fix-pull-hanging
Sep 29, 2025
Merged

fix: Docker pull hanging on Windows#76
rboni-dk merged 1 commit into
mainfrom
fix-pull-hanging

Conversation

@rboni-dk

Copy link
Copy Markdown
Contributor

IO buffers are smaller on Windows and python's implementation of Popen.communicate() does different things on Windows too (uses thread). Not using communicate is the most likely cause for the process to hang on that OS, so this PR is refactoring how we read from the command output streams to use communicate.

@github-actions

Copy link
Copy Markdown

@rboni-dk rboni-dk changed the title draft: fix: Docker pull hanging on Windows fix: Docker pull hanging on Windows Sep 29, 2025
@rboni-dk
rboni-dk merged commit 59e4c75 into main Sep 29, 2025
3 checks passed
@rboni-dk
rboni-dk deleted the fix-pull-hanging branch September 29, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants