Add FFE test case for empty targeting key evaluation #6046
+81
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new flag definition and test case to verify that flag evaluation succeeds when targeting key is an empty string. The flag should still match the allocation and return the expected value.
This tests that tracers properly handle empty targeting keys during evaluation (separate from exposure event handling).
Motivation
SDK Specification
While developing another system test to validate that exposures are being sent for empty targeting keys, found that in Java and NodeJS implementations an empty targeting key was causing evaluations to return the programmatic default.
Changes
Decisions
Why both inline skip AND dedicated test?
This dual approach ensures the bugs are tracked properly while preventing CI failures.
Next Steps
Language: Java
JIRA: FFL-1729
Fix: open-feature/java-sdk#1807
Action: Merge upstream PR, then remove @bug decorator
────────────────────────────────────────
Language: Node.js
JIRA: FFL-1730
Fix: https://github.com/DataDog/openfeature-js-client/pull/new/leo/allow-empty-targeting-key
Action: Merge internal PR, then remove @bug decorator
Once fixes are merged:
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present