feat(crashtracking): add interface for runtimes to report unhandled exception#1562
Open
feat(crashtracking): add interface for runtimes to report unhandled exception#1562
Conversation
📚 Documentation Check Results📦
|
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
🔒 Cargo Deny Results📦
|
gyuheon0h
force-pushed
the
gyuheon0h/prof-13749-unhandled-exception-ct
branch
from
81764f8 to
0d8bb6f
Compare
gyuheon0h
changed the title
gyuheon0h
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
- Coverage 70.97% 70.89% -0.08%
==========================================
Files 423 423
Lines 61800 62118 +318
==========================================
+ Hits 43864 44041 +177
- Misses 17936 18077 +141
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-02-13 23:03:41 Comparing candidate commit 3d82593 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
gleocadie
reviewed
Feb 13, 2026
Comment on lines
+477
to
+482
| if config.resolve_frames() != StacktraceCollection::Disabled { | ||
| unsafe { emit_backtrace_from_caller(pipe, config.resolve_frames())? }; | ||
| } | ||
|
|
||
| // Runtime-provided stack frames | ||
| emit_runtime_stack_from_stacktrace(pipe, runtime_stack)?; |
Contributor
There was a problem hiding this comment.
Why not putting the stack trace in the error.stack (since it's the stacktrace of that lead to the process termination) ?
Contributor
Author
There was a problem hiding this comment.
Good point
I am capturing the native stack trace, since we can capture that information anyways
I am putting the runtime stacks in the experimental section, because that is where runtime stacks go currently, vs native stack.
However, I think we should move the runtime stack section to error. Feels like we should have both native and runtime stacks in the error, since both should be supported as first class citizens soon.
Thoughts?
gleocadie
reviewed
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TLDR
report_unhandled_exceptionAPI for runtime-detected crashes (unhandled exceptions, errors) that are not triggered by OS signalsNOTICE: currently, the exception stack is put in the experimental field. This is a bit counter intuitive since it feels like the exception stack is being put somewhere where people won't look at first, but it is planned to make runtime stacks a first class citizen for crash reports, so this field will be surfaced upwards soon (this quarter)
Overview
This feature allows language runtimes (Ruby, Python, etc.) to report crashes detected at the runtime level, such as unhandled exceptions, through the existing crashtracker infrastructure. The runtime calls a single API, providing the error type, message, and a stack trace. libdatadog then handles the full data collection flow: native unwinding, profiler state (counters, spans, traces), process info,
/proc/self/maps, and formatting/uploading via the receiver.The crash report message is formatted as:
Process was terminated due to an unhandled exception of type '{error_type}'. Message: "{error_message}"The runtime-provided stack goes into
experimental.runtime_stack, while the native backtrace captured by libdatadog goes intoerror.stack. Nosig_infoorucontextis collected since no signal is involved.Prerequisite: The application must have already called
ddog_crasht_init()to prime the crashtracker for signal-based crash tracking. This API reuses the stored config, metadata, and receiver configuration.What was existing that changed
DD_CRASHTRACK_BEGIN_ERROR_KIND/DD_CRASHTRACK_END_ERROR_KINDblock. The receiver now parses an explicit error kind from the collector instead of hardcodingUnixSignal. Old receivers gracefully ignore the new block and default toUnixSignal(backward compatible).is_ping_ready()now acceptserror.kind.is_some()as an alternative tosig_info.is_some(), so crash pings fire for unhandled exception reports too.emit_absolute_addresses_for_frame()as a shared helper used by both the signal-path and caller-path backtrace emitters.FFI usage example
Example output
Motivation
Current API requires runtimes to manually extract all this information and send the ping/report, which is all work that can be done on the libdatadog side.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.