-
Notifications
You must be signed in to change notification settings - Fork 16
feat(profiling)!: take sample types by enum #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
BenchmarksComparisonBenchmark execution time: 2026-01-14 23:35:50 Comparing candidate commit bd8abfc in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1450 +/- ##
=======================================
Coverage 71.27% 71.27%
=======================================
Files 416 416
Lines 66798 66852 +54
=======================================
+ Hits 47608 47647 +39
- Misses 19190 19205 +15
🚀 New features to boost your workflow:
|
e987b42 to
79ff759
Compare
79ff759 to
bd8abfc
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
What does this PR do?
Takes sample types by enum rather than as tuples of strings.
Motivation
Additional Notes
Added experimental enum variants to allow users to experiment without needing to update libdatadog.
How to test the change?
Describe here in detail how the change can be validated.