Skip to content

Conversation

@cataphract
Copy link
Contributor

@cataphract cataphract commented Jan 16, 2026

Description

Passing integration and system-tests.

Further integration into sidecar and protocol changes pending.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

- Upgrade testcontainers
- Add some assertions
- Better debug output for metrics
@cataphract cataphract requested review from a team as code owners January 16, 2026 16:47
@cataphract cataphract marked this pull request as draft January 16, 2026 16:47
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 16, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 25 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 696c16b500000000f813c730ad531a0f
tid: 696c16b500000000
hexProcessTraceId: f813c730ad531a0f
hexProcessSpanId: bbc992fa52ed4725
processTraceId: 17875850357843892751
processSpanId: 13531508159242127141

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 696c16920000000038afa2036f70e4fc
tid: 696c169200000000
hexProcessTraceId: 38afa2036f70e4fc
hexProcessSpanId: b665851e65a4c58c
processTraceId: 4084661522686600444
processSpanId: 13143057453151470988
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fb4432d | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 49.00271% with 2071 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.94%. Comparing base (192a4a1) to head (fb4432d).

Files with missing lines Patch % Lines
appsec/helper-rust/src/client.rs 0.00% 563 Missing ⚠️
appsec/helper-rust/src/service.rs 52.69% 219 Missing ⚠️
appsec/helper-rust/src/service/waf_diag.rs 20.58% 189 Missing ⚠️
appsec/helper-rust/src/lib.rs 0.00% 186 Missing ⚠️
appsec/helper-rust/src/client/metrics.rs 0.00% 138 Missing ⚠️
appsec/helper-rust/src/rc.rs 73.73% 125 Missing ⚠️
appsec/helper-rust/src/telemetry/sidecar.rs 0.00% 96 Missing ⚠️
appsec/helper-rust/src/rc_notify.rs 0.00% 86 Missing ⚠️
appsec/helper-rust/src/service/limiter.rs 8.33% 66 Missing ⚠️
appsec/helper-rust/src/telemetry.rs 25.31% 59 Missing ⚠️
... and 10 more
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           glopes/appsec-curl    #3581      +/-   ##
======================================================
- Coverage               61.95%   58.94%   -3.02%     
======================================================
  Files                     142      162      +20     
  Lines                   13835    17896    +4061     
  Branches                 1847     1847              
======================================================
+ Hits                     8572    10548    +1976     
- Misses                   4433     6517    +2084     
- Partials                  830      831       +1     
Flag Coverage Δ
helper-rust-unit 49.00% <49.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appsec/helper-rust/src/client/attributes.rs 97.76% <97.76%> (ø)
appsec/helper-rust/src/client/log.rs 0.00% <0.00%> (ø)
appsec/helper-rust/src/config.rs 74.39% <74.39%> (ø)
appsec/helper-rust/src/service/updateable_waf.rs 84.15% <84.15%> (ø)
appsec/helper-rust/src/server.rs 0.00% <0.00%> (ø)
appsec/helper-rust/src/service/config_manager.rs 67.93% <67.93%> (ø)
appsec/helper-rust/src/service/sampler.rs 88.31% <88.31%> (ø)
appsec/helper-rust/src/client/protocol.rs 89.55% <89.55%> (ø)
appsec/helper-rust/src/lock.rs 59.45% <59.45%> (ø)
appsec/helper-rust/src/service/waf_ruleset.rs 25.97% <25.97%> (ø)
... and 10 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192a4a1...fb4432d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2026

Benchmarks [ appsec ]

Benchmark execution time: 2026-01-17 20:33:05

Comparing candidate commit 42ed7a1 in PR branch glopes/helper-rust with baseline commit 192a4a1 in branch glopes/appsec-curl.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-01-17 20:59:58

Comparing candidate commit 42ed7a1 in PR branch glopes/helper-rust with baseline commit 192a4a1 in branch glopes/appsec-curl.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 192 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline

  • 🟥 execution_time [+95.357µs; +360.203µs] or [+2.910%; +10.993%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-5.816µs; -4.864µs] or [-5.269%; -4.406%]

@cataphract cataphract force-pushed the glopes/helper-rust branch 7 times, most recently from cc329b7 to 42ed7a1 Compare January 17, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants