-
Notifications
You must be signed in to change notification settings - Fork 324
Support DD_TRACE_LOG_LEVEL #10441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DD_TRACE_LOG_LEVEL #10441
Conversation
88dd89b to
47e8ed6
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~47e8ed6371, baseline=1.59.0-SNAPSHOT~285f51e6df
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091425
Total [baseline] (10.84 s) : 0, 10839655
Agent [candidate] (1.091 s) : 0, 1090959
Total [candidate] (10.823 s) : 0, 10823338
section appsec
Agent [baseline] (1.273 s) : 0, 1273359
Total [baseline] (11.019 s) : 0, 11019405
Agent [candidate] (1.278 s) : 0, 1277676
Total [candidate] (10.995 s) : 0, 10994852
section iast
Agent [baseline] (1.231 s) : 0, 1231318
Total [baseline] (11.157 s) : 0, 11156724
Agent [candidate] (1.23 s) : 0, 1229788
Total [candidate] (11.205 s) : 0, 11205421
section profiling
Agent [baseline] (1.208 s) : 0, 1208447
Total [baseline] (10.858 s) : 0, 10858207
Agent [candidate] (1.205 s) : 0, 1205341
Total [candidate] (10.88 s) : 0, 10880287
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~47e8ed6371, baseline=1.59.0-SNAPSHOT~285f51e6df
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (653.577 ms) : 0, 653577
BytebuddyAgent [candidate] (653.424 ms) : 0, 653424
GlobalTracer [baseline] (286.462 ms) : 0, 286462
GlobalTracer [candidate] (286.312 ms) : 0, 286312
AppSec [baseline] (32.912 ms) : 0, 32912
AppSec [candidate] (32.783 ms) : 0, 32783
Debugger [baseline] (66.002 ms) : 0, 66002
Debugger [candidate] (67.48 ms) : 0, 67480
Remote Config [baseline] (610.034 µs) : 0, 610
Remote Config [candidate] (598.748 µs) : 0, 599
Telemetry [baseline] (8.968 ms) : 0, 8968
Telemetry [candidate] (8.956 ms) : 0, 8956
Flare Poller [baseline] (6.205 ms) : 0, 6205
Flare Poller [candidate] (4.626 ms) : 0, 4626
section appsec
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (695.341 ms) : 0, 695341
BytebuddyAgent [candidate] (697.719 ms) : 0, 697719
GlobalTracer [baseline] (262.117 ms) : 0, 262117
GlobalTracer [candidate] (264.189 ms) : 0, 264189
AppSec [baseline] (173.445 ms) : 0, 173445
AppSec [candidate] (174.402 ms) : 0, 174402
Debugger [baseline] (67.329 ms) : 0, 67329
Debugger [candidate] (66.155 ms) : 0, 66155
Remote Config [baseline] (712.455 µs) : 0, 712
Remote Config [candidate] (690.62 µs) : 0, 691
Telemetry [baseline] (9.361 ms) : 0, 9361
Telemetry [candidate] (9.25 ms) : 0, 9250
Flare Poller [baseline] (3.578 ms) : 0, 3578
Flare Poller [candidate] (3.609 ms) : 0, 3609
IAST [baseline] (24.746 ms) : 0, 24746
IAST [candidate] (24.987 ms) : 0, 24987
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (794.347 ms) : 0, 794347
BytebuddyAgent [candidate] (794.047 ms) : 0, 794047
GlobalTracer [baseline] (260.274 ms) : 0, 260274
GlobalTracer [candidate] (259.93 ms) : 0, 259930
AppSec [baseline] (32.82 ms) : 0, 32820
AppSec [candidate] (35.221 ms) : 0, 35221
Debugger [baseline] (67.635 ms) : 0, 67635
Debugger [candidate] (64.613 ms) : 0, 64613
Remote Config [baseline] (545.546 µs) : 0, 546
Remote Config [candidate] (534.825 µs) : 0, 535
Telemetry [baseline] (8.5 ms) : 0, 8500
Telemetry [candidate] (8.47 ms) : 0, 8470
Flare Poller [baseline] (3.474 ms) : 0, 3474
Flare Poller [candidate] (3.468 ms) : 0, 3468
IAST [baseline] (27.194 ms) : 0, 27194
IAST [candidate] (27.057 ms) : 0, 27057
section profiling
ProfilingAgent [baseline] (98.113 ms) : 0, 98113
ProfilingAgent [candidate] (97.091 ms) : 0, 97091
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (701.229 ms) : 0, 701229
BytebuddyAgent [candidate] (700.202 ms) : 0, 700202
GlobalTracer [baseline] (224.767 ms) : 0, 224767
GlobalTracer [candidate] (224.217 ms) : 0, 224217
AppSec [baseline] (32.482 ms) : 0, 32482
AppSec [candidate] (32.315 ms) : 0, 32315
Debugger [baseline] (67.757 ms) : 0, 67757
Debugger [candidate] (67.52 ms) : 0, 67520
Remote Config [baseline] (616.267 µs) : 0, 616
Remote Config [candidate] (613.97 µs) : 0, 614
Telemetry [baseline] (8.838 ms) : 0, 8838
Telemetry [candidate] (8.792 ms) : 0, 8792
Flare Poller [baseline] (3.639 ms) : 0, 3639
Flare Poller [candidate] (3.607 ms) : 0, 3607
Profiling [baseline] (98.702 ms) : 0, 98702
Profiling [candidate] (97.66 ms) : 0, 97660
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~47e8ed6371, baseline=1.59.0-SNAPSHOT~285f51e6df
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1093401
Total [baseline] (8.735 s) : 0, 8735241
Agent [candidate] (1.1 s) : 0, 1100362
Total [candidate] (8.757 s) : 0, 8756625
section iast
Agent [baseline] (1.238 s) : 0, 1238369
Total [baseline] (9.338 s) : 0, 9338279
Agent [candidate] (1.227 s) : 0, 1227115
Total [candidate] (9.291 s) : 0, 9290850
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~47e8ed6371, baseline=1.59.0-SNAPSHOT~285f51e6df
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (655.303 ms) : 0, 655303
BytebuddyAgent [candidate] (660.763 ms) : 0, 660763
GlobalTracer [baseline] (287.226 ms) : 0, 287226
GlobalTracer [candidate] (289.012 ms) : 0, 289012
AppSec [baseline] (32.948 ms) : 0, 32948
AppSec [candidate] (33.22 ms) : 0, 33220
Debugger [baseline] (67.775 ms) : 0, 67775
Debugger [candidate] (66.552 ms) : 0, 66552
Remote Config [baseline] (613.801 µs) : 0, 614
Remote Config [candidate] (609.627 µs) : 0, 610
Telemetry [baseline] (8.922 ms) : 0, 8922
Telemetry [candidate] (8.808 ms) : 0, 8808
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (4.5 ms) : 0, 4500
section iast
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.169 ms) : 0, 1169
BytebuddyAgent [baseline] (801.864 ms) : 0, 801864
BytebuddyAgent [candidate] (791.991 ms) : 0, 791991
GlobalTracer [baseline] (260.527 ms) : 0, 260527
GlobalTracer [candidate] (258.884 ms) : 0, 258884
IAST [baseline] (26.989 ms) : 0, 26989
IAST [candidate] (26.947 ms) : 0, 26947
AppSec [baseline] (33.558 ms) : 0, 33558
AppSec [candidate] (33.446 ms) : 0, 33446
Debugger [baseline] (66.176 ms) : 0, 66176
Debugger [candidate] (66.787 ms) : 0, 66787
Remote Config [baseline] (538.248 µs) : 0, 538
Remote Config [candidate] (540.072 µs) : 0, 540
Telemetry [baseline] (8.497 ms) : 0, 8497
Telemetry [candidate] (8.566 ms) : 0, 8566
Flare Poller [baseline] (3.519 ms) : 0, 3519
Flare Poller [candidate] (3.521 ms) : 0, 3521
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~47e8ed6371, baseline=1.59.0-SNAPSHOT~285f51e6df
dateFormat X
axisFormat %s
section baseline
no_agent (18.215 ms) : 18027, 18402
. : milestone, 18215,
appsec (18.903 ms) : 18713, 19094
. : milestone, 18903,
code_origins (17.704 ms) : 17531, 17877
. : milestone, 17704,
iast (17.663 ms) : 17486, 17840
. : milestone, 17663,
profiling (18.625 ms) : 18440, 18810
. : milestone, 18625,
tracing (18.014 ms) : 17836, 18193
. : milestone, 18014,
section candidate
no_agent (18.285 ms) : 18098, 18471
. : milestone, 18285,
appsec (18.918 ms) : 18729, 19106
. : milestone, 18918,
code_origins (17.494 ms) : 17319, 17669
. : milestone, 17494,
iast (17.776 ms) : 17599, 17953
. : milestone, 17776,
profiling (18.388 ms) : 18202, 18574
. : milestone, 18388,
tracing (17.55 ms) : 17375, 17726
. : milestone, 17550,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~47e8ed6371, baseline=1.59.0-SNAPSHOT~285f51e6df
dateFormat X
axisFormat %s
section baseline
no_agent (1.183 ms) : 1172, 1195
. : milestone, 1183,
iast (3.112 ms) : 3071, 3153
. : milestone, 3112,
iast_FULL (5.646 ms) : 5590, 5702
. : milestone, 5646,
iast_GLOBAL (3.615 ms) : 3564, 3666
. : milestone, 3615,
profiling (1.892 ms) : 1876, 1907
. : milestone, 1892,
tracing (1.783 ms) : 1768, 1798
. : milestone, 1783,
section candidate
no_agent (1.209 ms) : 1196, 1222
. : milestone, 1209,
iast (3.216 ms) : 3170, 3261
. : milestone, 3216,
iast_FULL (5.873 ms) : 5813, 5932
. : milestone, 5873,
iast_GLOBAL (3.683 ms) : 3629, 3737
. : milestone, 3683,
profiling (2.085 ms) : 2066, 2104
. : milestone, 2085,
tracing (1.834 ms) : 1819, 1849
. : milestone, 1834,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~47e8ed6371, baseline=1.59.0-SNAPSHOT~285f51e6df
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.737 ms) : 3519, 3956
. : milestone, 3737,
iast (2.213 ms) : 2148, 2278
. : milestone, 2213,
iast_GLOBAL (2.261 ms) : 2195, 2326
. : milestone, 2261,
profiling (2.495 ms) : 2333, 2657
. : milestone, 2495,
tracing (2.053 ms) : 2001, 2104
. : milestone, 2053,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.696 ms) : 3480, 3913
. : milestone, 3696,
iast (2.22 ms) : 2155, 2285
. : milestone, 2220,
iast_GLOBAL (2.257 ms) : 2191, 2322
. : milestone, 2257,
profiling (2.074 ms) : 2022, 2127
. : milestone, 2074,
tracing (2.035 ms) : 1984, 2086
. : milestone, 2035,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~47e8ed6371, baseline=1.59.0-SNAPSHOT~285f51e6df
dateFormat X
axisFormat %s
section baseline
no_agent (14.779 s) : 14779000, 14779000
. : milestone, 14779000,
appsec (14.743 s) : 14743000, 14743000
. : milestone, 14743000,
iast (17.669 s) : 17669000, 17669000
. : milestone, 17669000,
iast_GLOBAL (17.745 s) : 17745000, 17745000
. : milestone, 17745000,
profiling (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
tracing (14.778 s) : 14778000, 14778000
. : milestone, 14778000,
section candidate
no_agent (15.562 s) : 15562000, 15562000
. : milestone, 15562000,
appsec (14.692 s) : 14692000, 14692000
. : milestone, 14692000,
iast (18.012 s) : 18012000, 18012000
. : milestone, 18012000,
iast_GLOBAL (17.859 s) : 17859000, 17859000
. : milestone, 17859000,
profiling (14.936 s) : 14936000, 14936000
. : milestone, 14936000,
tracing (14.788 s) : 14788000, 14788000
. : milestone, 14788000,
|
ygree
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What Does This Do
Support
DD_TRACE_LOG_LEVELas an alias forDD_LOG_LEVEL, withDD_TRACE_LOG_LEVELtaking precedence.Motivation
Consistency with other languages, provides a way for users to control the tracer's log level separate to the main agent.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]