-
Notifications
You must be signed in to change notification settings - Fork 324
Fixed missing logging placeholders. #10439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
sarahchen6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~ad03cb59fd, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088072
Total [baseline] (10.766 s) : 0, 10765790
Agent [candidate] (1.097 s) : 0, 1097447
Total [candidate] (10.779 s) : 0, 10779036
section appsec
Agent [baseline] (1.268 s) : 0, 1267919
Total [baseline] (10.943 s) : 0, 10942671
Agent [candidate] (1.272 s) : 0, 1271761
Total [candidate] (11.031 s) : 0, 11031345
section iast
Agent [baseline] (1.228 s) : 0, 1228044
Total [baseline] (11.213 s) : 0, 11213410
Agent [candidate] (1.229 s) : 0, 1229341
Total [candidate] (11.185 s) : 0, 11185172
section profiling
Agent [baseline] (1.206 s) : 0, 1206283
Total [baseline] (10.933 s) : 0, 10933053
Agent [candidate] (1.209 s) : 0, 1209184
Total [candidate] (10.888 s) : 0, 10888148
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~ad03cb59fd, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (651.076 ms) : 0, 651076
BytebuddyAgent [candidate] (657.671 ms) : 0, 657671
GlobalTracer [baseline] (286.113 ms) : 0, 286113
GlobalTracer [candidate] (288.444 ms) : 0, 288444
AppSec [baseline] (32.978 ms) : 0, 32978
AppSec [candidate] (33.087 ms) : 0, 33087
Debugger [baseline] (66.456 ms) : 0, 66456
Debugger [candidate] (68.102 ms) : 0, 68102
Remote Config [baseline] (604.807 µs) : 0, 605
Remote Config [candidate] (593.377 µs) : 0, 593
Telemetry [baseline] (8.908 ms) : 0, 8908
Telemetry [candidate] (8.88 ms) : 0, 8880
Flare Poller [baseline] (5.268 ms) : 0, 5268
Flare Poller [candidate] (3.78 ms) : 0, 3780
section appsec
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (691.181 ms) : 0, 691181
BytebuddyAgent [candidate] (693.087 ms) : 0, 693087
GlobalTracer [baseline] (262.311 ms) : 0, 262311
GlobalTracer [candidate] (262.767 ms) : 0, 262767
AppSec [baseline] (173.288 ms) : 0, 173288
AppSec [candidate] (172.896 ms) : 0, 172896
Debugger [baseline] (66.54 ms) : 0, 66540
Debugger [candidate] (67.865 ms) : 0, 67865
Remote Config [baseline] (684.954 µs) : 0, 685
Remote Config [candidate] (693.199 µs) : 0, 693
Telemetry [baseline] (9.176 ms) : 0, 9176
Telemetry [candidate] (9.345 ms) : 0, 9345
Flare Poller [baseline] (3.573 ms) : 0, 3573
Flare Poller [candidate] (3.696 ms) : 0, 3696
IAST [baseline] (24.462 ms) : 0, 24462
IAST [candidate] (24.673 ms) : 0, 24673
section iast
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (793.126 ms) : 0, 793126
BytebuddyAgent [candidate] (793.841 ms) : 0, 793841
GlobalTracer [baseline] (259.382 ms) : 0, 259382
GlobalTracer [candidate] (259.507 ms) : 0, 259507
AppSec [baseline] (34.322 ms) : 0, 34322
AppSec [candidate] (33.342 ms) : 0, 33342
Debugger [baseline] (65.382 ms) : 0, 65382
Debugger [candidate] (66.739 ms) : 0, 66739
Remote Config [baseline] (539.674 µs) : 0, 540
Remote Config [candidate] (528.245 µs) : 0, 528
Telemetry [baseline] (8.405 ms) : 0, 8405
Telemetry [candidate] (8.472 ms) : 0, 8472
Flare Poller [baseline] (3.437 ms) : 0, 3437
Flare Poller [candidate] (3.468 ms) : 0, 3468
IAST [baseline] (26.959 ms) : 0, 26959
IAST [candidate] (26.997 ms) : 0, 26997
section profiling
ProfilingAgent [baseline] (97.393 ms) : 0, 97393
ProfilingAgent [candidate] (97.085 ms) : 0, 97085
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (700.689 ms) : 0, 700689
BytebuddyAgent [candidate] (702.794 ms) : 0, 702794
GlobalTracer [baseline] (224.652 ms) : 0, 224652
GlobalTracer [candidate] (224.954 ms) : 0, 224954
AppSec [baseline] (32.242 ms) : 0, 32242
AppSec [candidate] (32.383 ms) : 0, 32383
Debugger [baseline] (67.29 ms) : 0, 67290
Debugger [candidate] (67.656 ms) : 0, 67656
Remote Config [baseline] (595.425 µs) : 0, 595
Remote Config [candidate] (602.439 µs) : 0, 602
Telemetry [baseline] (8.8 ms) : 0, 8800
Telemetry [candidate] (8.892 ms) : 0, 8892
Flare Poller [baseline] (3.616 ms) : 0, 3616
Flare Poller [candidate] (3.68 ms) : 0, 3680
Profiling [baseline] (97.975 ms) : 0, 97975
Profiling [candidate] (97.653 ms) : 0, 97653
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~ad03cb59fd, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1094136
Total [baseline] (8.773 s) : 0, 8773310
Agent [candidate] (1.101 s) : 0, 1100507
Total [candidate] (8.774 s) : 0, 8773541
section iast
Agent [baseline] (1.226 s) : 0, 1226022
Total [baseline] (9.345 s) : 0, 9344971
Agent [candidate] (1.238 s) : 0, 1238043
Total [candidate] (9.389 s) : 0, 9389097
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~ad03cb59fd, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (655.841 ms) : 0, 655841
BytebuddyAgent [candidate] (661.036 ms) : 0, 661036
GlobalTracer [baseline] (287.5 ms) : 0, 287500
GlobalTracer [candidate] (288.895 ms) : 0, 288895
AppSec [baseline] (33.224 ms) : 0, 33224
AppSec [candidate] (33.09 ms) : 0, 33090
Debugger [baseline] (65.925 ms) : 0, 65925
Debugger [candidate] (65.694 ms) : 0, 65694
Remote Config [baseline] (603.743 µs) : 0, 604
Remote Config [candidate] (606.48 µs) : 0, 606
Telemetry [baseline] (8.868 ms) : 0, 8868
Telemetry [candidate] (8.839 ms) : 0, 8839
Flare Poller [baseline] (5.436 ms) : 0, 5436
Flare Poller [candidate] (5.281 ms) : 0, 5281
section iast
crashtracking [baseline] (1.172 ms) : 0, 1172
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (791.4 ms) : 0, 791400
BytebuddyAgent [candidate] (799.784 ms) : 0, 799784
GlobalTracer [baseline] (259.412 ms) : 0, 259412
GlobalTracer [candidate] (261.455 ms) : 0, 261455
AppSec [baseline] (34.306 ms) : 0, 34306
AppSec [candidate] (34.492 ms) : 0, 34492
Debugger [baseline] (65.101 ms) : 0, 65101
Debugger [candidate] (65.643 ms) : 0, 65643
Remote Config [baseline] (540.14 µs) : 0, 540
Remote Config [candidate] (557.695 µs) : 0, 558
Telemetry [baseline] (8.387 ms) : 0, 8387
Telemetry [candidate] (8.536 ms) : 0, 8536
Flare Poller [baseline] (3.472 ms) : 0, 3472
Flare Poller [candidate] (3.555 ms) : 0, 3555
IAST [baseline] (26.916 ms) : 0, 26916
IAST [candidate] (27.308 ms) : 0, 27308
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~ad03cb59fd, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.177 ms) : 1165, 1188
. : milestone, 1177,
iast (3.175 ms) : 3132, 3219
. : milestone, 3175,
iast_FULL (5.751 ms) : 5694, 5808
. : milestone, 5751,
iast_GLOBAL (3.504 ms) : 3449, 3558
. : milestone, 3504,
profiling (2.001 ms) : 1984, 2017
. : milestone, 2001,
tracing (1.829 ms) : 1813, 1844
. : milestone, 1829,
section candidate
no_agent (1.188 ms) : 1176, 1199
. : milestone, 1188,
iast (3.222 ms) : 3183, 3261
. : milestone, 3222,
iast_FULL (5.901 ms) : 5842, 5960
. : milestone, 5901,
iast_GLOBAL (3.601 ms) : 3543, 3660
. : milestone, 3601,
profiling (2.009 ms) : 1992, 2026
. : milestone, 2009,
tracing (1.858 ms) : 1841, 1876
. : milestone, 1858,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~ad03cb59fd, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section baseline
no_agent (18.231 ms) : 18043, 18419
. : milestone, 18231,
appsec (19.758 ms) : 19551, 19966
. : milestone, 19758,
code_origins (17.678 ms) : 17501, 17855
. : milestone, 17678,
iast (18.145 ms) : 17967, 18323
. : milestone, 18145,
profiling (18.855 ms) : 18664, 19045
. : milestone, 18855,
tracing (17.81 ms) : 17634, 17987
. : milestone, 17810,
section candidate
no_agent (17.175 ms) : 17006, 17344
. : milestone, 17175,
appsec (18.606 ms) : 18418, 18794
. : milestone, 18606,
code_origins (17.887 ms) : 17710, 18065
. : milestone, 17887,
iast (18.969 ms) : 18777, 19160
. : milestone, 18969,
profiling (18.726 ms) : 18535, 18917
. : milestone, 18726,
tracing (17.542 ms) : 17366, 17718
. : milestone, 17542,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~ad03cb59fd, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.733 ms) : 3514, 3952
. : milestone, 3733,
iast (2.217 ms) : 2153, 2282
. : milestone, 2217,
iast_GLOBAL (2.269 ms) : 2204, 2335
. : milestone, 2269,
profiling (2.08 ms) : 2027, 2133
. : milestone, 2080,
tracing (2.048 ms) : 1997, 2099
. : milestone, 2048,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.671 ms) : 3454, 3887
. : milestone, 3671,
iast (2.223 ms) : 2158, 2288
. : milestone, 2223,
iast_GLOBAL (2.258 ms) : 2193, 2324
. : milestone, 2258,
profiling (2.091 ms) : 2036, 2145
. : milestone, 2091,
tracing (2.06 ms) : 2009, 2112
. : milestone, 2060,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~ad03cb59fd, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section baseline
no_agent (14.894 s) : 14894000, 14894000
. : milestone, 14894000,
appsec (14.719 s) : 14719000, 14719000
. : milestone, 14719000,
iast (18.484 s) : 18484000, 18484000
. : milestone, 18484000,
iast_GLOBAL (18.109 s) : 18109000, 18109000
. : milestone, 18109000,
profiling (15.137 s) : 15137000, 15137000
. : milestone, 15137000,
tracing (14.642 s) : 14642000, 14642000
. : milestone, 14642000,
section candidate
no_agent (15.289 s) : 15289000, 15289000
. : milestone, 15289000,
appsec (14.637 s) : 14637000, 14637000
. : milestone, 14637000,
iast (18.183 s) : 18183000, 18183000
. : milestone, 18183000,
iast_GLOBAL (17.773 s) : 17773000, 17773000
. : milestone, 17773000,
profiling (15.257 s) : 15257000, 15257000
. : milestone, 15257000,
tracing (14.741 s) : 14741000, 14741000
. : milestone, 14741000,
|
What Does This Do
Refactors logging statements to use parameterized placeholders instead of string concatenation.
Motivation
Using placeholders is the idiomatic and recommended way to log. It improves readability, avoids unnecessary string allocation, and aligns with best practices for logging.
Additional Notes
Found by IDEA static analysis.