-
Notifications
You must be signed in to change notification settings - Fork 324
feat(websockets): enable websocket instrumentation by default #10437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~4c25eb4215, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.105 s) : 0, 1105256
Total [baseline] (10.913 s) : 0, 10913454
Agent [candidate] (1.1 s) : 0, 1099766
Total [candidate] (11.096 s) : 0, 11096232
section appsec
Agent [baseline] (1.273 s) : 0, 1272736
Total [baseline] (11.113 s) : 0, 11112988
Agent [candidate] (1.275 s) : 0, 1275494
Total [candidate] (11.239 s) : 0, 11238872
section iast
Agent [baseline] (1.229 s) : 0, 1228831
Total [baseline] (11.159 s) : 0, 11158581
Agent [candidate] (1.25 s) : 0, 1250287
Total [candidate] (11.394 s) : 0, 11393702
section profiling
Agent [baseline] (1.225 s) : 0, 1224517
Total [baseline] (11.046 s) : 0, 11045762
Agent [candidate] (1.214 s) : 0, 1214029
Total [candidate] (11.01 s) : 0, 11009923
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~4c25eb4215, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (661.883 ms) : 0, 661883
BytebuddyAgent [candidate] (658.326 ms) : 0, 658326
GlobalTracer [baseline] (290.452 ms) : 0, 290452
GlobalTracer [candidate] (289.196 ms) : 0, 289196
AppSec [baseline] (33.389 ms) : 0, 33389
AppSec [candidate] (33.38 ms) : 0, 33380
Debugger [baseline] (67.425 ms) : 0, 67425
Debugger [candidate] (67.137 ms) : 0, 67137
Remote Config [baseline] (621.437 µs) : 0, 621
Remote Config [candidate] (608.659 µs) : 0, 609
Telemetry [baseline] (9.024 ms) : 0, 9024
Telemetry [candidate] (9.033 ms) : 0, 9033
Flare Poller [baseline] (5.329 ms) : 0, 5329
Flare Poller [candidate] (5.254 ms) : 0, 5254
section appsec
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.17 ms) : 0, 1170
BytebuddyAgent [baseline] (693.579 ms) : 0, 693579
BytebuddyAgent [candidate] (694.399 ms) : 0, 694399
GlobalTracer [baseline] (262.682 ms) : 0, 262682
GlobalTracer [candidate] (263.335 ms) : 0, 263335
IAST [baseline] (24.673 ms) : 0, 24673
IAST [candidate] (24.621 ms) : 0, 24621
AppSec [baseline] (173.825 ms) : 0, 173825
AppSec [candidate] (174.712 ms) : 0, 174712
Debugger [baseline] (67.448 ms) : 0, 67448
Debugger [candidate] (67.647 ms) : 0, 67647
Remote Config [baseline] (702.212 µs) : 0, 702
Remote Config [candidate] (741.611 µs) : 0, 742
Telemetry [baseline] (9.427 ms) : 0, 9427
Telemetry [candidate] (9.765 ms) : 0, 9765
Flare Poller [baseline] (3.649 ms) : 0, 3649
Flare Poller [candidate] (3.628 ms) : 0, 3628
section iast
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (792.895 ms) : 0, 792895
BytebuddyAgent [candidate] (808.705 ms) : 0, 808705
GlobalTracer [baseline] (259.679 ms) : 0, 259679
GlobalTracer [candidate] (262.641 ms) : 0, 262641
IAST [baseline] (26.985 ms) : 0, 26985
IAST [candidate] (27.43 ms) : 0, 27430
AppSec [baseline] (35.301 ms) : 0, 35301
AppSec [candidate] (34.711 ms) : 0, 34711
Debugger [baseline] (64.979 ms) : 0, 64979
Debugger [candidate] (67.004 ms) : 0, 67004
Remote Config [baseline] (534.422 µs) : 0, 534
Remote Config [candidate] (545.23 µs) : 0, 545
Telemetry [baseline] (8.48 ms) : 0, 8480
Telemetry [candidate] (8.724 ms) : 0, 8724
Flare Poller [baseline] (3.458 ms) : 0, 3458
Flare Poller [candidate] (3.582 ms) : 0, 3582
section profiling
crashtracking [baseline] (1.256 ms) : 0, 1256
crashtracking [candidate] (1.226 ms) : 0, 1226
BytebuddyAgent [baseline] (712.413 ms) : 0, 712413
BytebuddyAgent [candidate] (707.002 ms) : 0, 707002
GlobalTracer [baseline] (227.716 ms) : 0, 227716
GlobalTracer [candidate] (225.34 ms) : 0, 225340
AppSec [baseline] (33.112 ms) : 0, 33112
AppSec [candidate] (32.558 ms) : 0, 32558
Debugger [baseline] (68.7 ms) : 0, 68700
Debugger [candidate] (67.431 ms) : 0, 67431
Remote Config [baseline] (635.585 µs) : 0, 636
Remote Config [candidate] (604.537 µs) : 0, 605
Telemetry [baseline] (8.963 ms) : 0, 8963
Telemetry [candidate] (8.893 ms) : 0, 8893
Flare Poller [baseline] (3.696 ms) : 0, 3696
Flare Poller [candidate] (4.211 ms) : 0, 4211
ProfilingAgent [baseline] (97.583 ms) : 0, 97583
ProfilingAgent [candidate] (96.678 ms) : 0, 96678
Profiling [baseline] (98.167 ms) : 0, 98167
Profiling [candidate] (97.251 ms) : 0, 97251
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~4c25eb4215, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1097798
Total [baseline] (8.785 s) : 0, 8785287
Agent [candidate] (1.101 s) : 0, 1100927
Total [candidate] (8.813 s) : 0, 8813228
section iast
Agent [baseline] (1.227 s) : 0, 1226969
Total [baseline] (9.32 s) : 0, 9319854
Agent [candidate] (1.234 s) : 0, 1234096
Total [candidate] (9.372 s) : 0, 9371506
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~4c25eb4215, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (657.202 ms) : 0, 657202
BytebuddyAgent [candidate] (660.414 ms) : 0, 660414
GlobalTracer [baseline] (289.094 ms) : 0, 289094
GlobalTracer [candidate] (289.177 ms) : 0, 289177
AppSec [baseline] (33.208 ms) : 0, 33208
AppSec [candidate] (33.339 ms) : 0, 33339
Debugger [baseline] (67.124 ms) : 0, 67124
Debugger [candidate] (67.888 ms) : 0, 67888
Remote Config [baseline] (616.498 µs) : 0, 616
Remote Config [candidate] (605.158 µs) : 0, 605
Telemetry [baseline] (8.941 ms) : 0, 8941
Telemetry [candidate] (8.922 ms) : 0, 8922
Flare Poller [baseline] (4.514 ms) : 0, 4514
Flare Poller [candidate] (3.638 ms) : 0, 3638
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (791.85 ms) : 0, 791850
BytebuddyAgent [candidate] (798.313 ms) : 0, 798313
GlobalTracer [baseline] (258.983 ms) : 0, 258983
GlobalTracer [candidate] (260.072 ms) : 0, 260072
IAST [baseline] (27.045 ms) : 0, 27045
IAST [candidate] (27.045 ms) : 0, 27045
AppSec [baseline] (33.606 ms) : 0, 33606
AppSec [candidate] (34.545 ms) : 0, 34545
Debugger [baseline] (66.415 ms) : 0, 66415
Debugger [candidate] (64.894 ms) : 0, 64894
Remote Config [baseline] (543.375 µs) : 0, 543
Remote Config [candidate] (539.832 µs) : 0, 540
Telemetry [baseline] (8.413 ms) : 0, 8413
Telemetry [candidate] (8.491 ms) : 0, 8491
Flare Poller [baseline] (3.478 ms) : 0, 3478
Flare Poller [candidate] (3.478 ms) : 0, 3478
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~4c25eb4215, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.198 ms) : 1187, 1209
. : milestone, 1198,
iast (3.442 ms) : 3396, 3488
. : milestone, 3442,
iast_FULL (5.835 ms) : 5776, 5894
. : milestone, 5835,
iast_GLOBAL (3.535 ms) : 3483, 3587
. : milestone, 3535,
profiling (2.016 ms) : 1998, 2035
. : milestone, 2016,
tracing (1.886 ms) : 1869, 1903
. : milestone, 1886,
section candidate
no_agent (1.193 ms) : 1181, 1204
. : milestone, 1193,
iast (3.135 ms) : 3095, 3176
. : milestone, 3135,
iast_FULL (5.953 ms) : 5893, 6013
. : milestone, 5953,
iast_GLOBAL (3.601 ms) : 3546, 3656
. : milestone, 3601,
profiling (2.106 ms) : 2088, 2125
. : milestone, 2106,
tracing (1.807 ms) : 1792, 1822
. : milestone, 1807,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~4c25eb4215, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section baseline
no_agent (17.908 ms) : 17727, 18089
. : milestone, 17908,
appsec (18.418 ms) : 18233, 18603
. : milestone, 18418,
code_origins (17.713 ms) : 17540, 17885
. : milestone, 17713,
iast (17.939 ms) : 17760, 18118
. : milestone, 17939,
profiling (18.738 ms) : 18549, 18927
. : milestone, 18738,
tracing (17.948 ms) : 17770, 18125
. : milestone, 17948,
section candidate
no_agent (17.835 ms) : 17651, 18019
. : milestone, 17835,
appsec (18.978 ms) : 18785, 19171
. : milestone, 18978,
code_origins (17.739 ms) : 17565, 17914
. : milestone, 17739,
iast (17.784 ms) : 17606, 17962
. : milestone, 17784,
profiling (18.591 ms) : 18404, 18778
. : milestone, 18591,
tracing (17.932 ms) : 17758, 18107
. : milestone, 17932,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~4c25eb4215, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section baseline
no_agent (15.603 s) : 15603000, 15603000
. : milestone, 15603000,
appsec (14.87 s) : 14870000, 14870000
. : milestone, 14870000,
iast (17.736 s) : 17736000, 17736000
. : milestone, 17736000,
iast_GLOBAL (17.871 s) : 17871000, 17871000
. : milestone, 17871000,
profiling (15.055 s) : 15055000, 15055000
. : milestone, 15055000,
tracing (14.762 s) : 14762000, 14762000
. : milestone, 14762000,
section candidate
no_agent (15.644 s) : 15644000, 15644000
. : milestone, 15644000,
appsec (14.368 s) : 14368000, 14368000
. : milestone, 14368000,
iast (17.96 s) : 17960000, 17960000
. : milestone, 17960000,
iast_GLOBAL (18.026 s) : 18026000, 18026000
. : milestone, 18026000,
profiling (15.5 s) : 15500000, 15500000
. : milestone, 15500000,
tracing (14.672 s) : 14672000, 14672000
. : milestone, 14672000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~4c25eb4215, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.644 ms) : 3430, 3859
. : milestone, 3644,
iast (2.203 ms) : 2138, 2267
. : milestone, 2203,
iast_GLOBAL (2.246 ms) : 2182, 2311
. : milestone, 2246,
profiling (2.047 ms) : 1994, 2099
. : milestone, 2047,
tracing (2.037 ms) : 1986, 2088
. : milestone, 2037,
section candidate
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (3.725 ms) : 3505, 3945
. : milestone, 3725,
iast (2.236 ms) : 2168, 2304
. : milestone, 2236,
iast_GLOBAL (2.273 ms) : 2205, 2342
. : milestone, 2273,
profiling (2.095 ms) : 2038, 2153
. : milestone, 2095,
tracing (2.052 ms) : 1999, 2106
. : milestone, 2052,
|
ygree
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| "aliases": ["DD_WEBSOCKET_ANALYTICS_SAMPLE_RATE"] | ||
| } | ||
| ], | ||
| "DD_TRACE_WEBSOCKET_ENABLED": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks an alias so should be also updated accordingly
amarziali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one minor comment. thanks for having opened it
What Does This Do
Enables websocket instrumentation by default
Motivation
Users want to enjoy websocket instrumentation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]