-
Notifications
You must be signed in to change notification settings - Fork 324
Fix servlet 3.x leaking to jetty 9.0.4 instrumentation tests #10368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~66d8189f0f, baseline=1.59.0-SNAPSHOT~291602a1aa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088072
Total [baseline] (10.887 s) : 0, 10887034
Agent [candidate] (1.095 s) : 0, 1095472
Total [candidate] (10.878 s) : 0, 10878303
section appsec
Agent [baseline] (1.269 s) : 0, 1269002
Total [baseline] (11.105 s) : 0, 11104539
Agent [candidate] (1.266 s) : 0, 1266012
Total [candidate] (11.046 s) : 0, 11046481
section iast
Agent [baseline] (1.235 s) : 0, 1235355
Total [baseline] (11.223 s) : 0, 11222820
Agent [candidate] (1.226 s) : 0, 1225883
Total [candidate] (11.222 s) : 0, 11222414
section profiling
Agent [baseline] (1.214 s) : 0, 1213735
Total [baseline] (10.976 s) : 0, 10975876
Agent [candidate] (1.216 s) : 0, 1216303
Total [candidate] (10.919 s) : 0, 10919341
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~66d8189f0f, baseline=1.59.0-SNAPSHOT~291602a1aa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (653.578 ms) : 0, 653578
BytebuddyAgent [candidate] (658.405 ms) : 0, 658405
GlobalTracer [baseline] (283.534 ms) : 0, 283534
GlobalTracer [candidate] (285.447 ms) : 0, 285447
AppSec [baseline] (32.65 ms) : 0, 32650
AppSec [candidate] (32.86 ms) : 0, 32860
Debugger [baseline] (67.917 ms) : 0, 67917
Debugger [candidate] (68.444 ms) : 0, 68444
Remote Config [baseline] (645.039 µs) : 0, 645
Remote Config [candidate] (648.074 µs) : 0, 648
Telemetry [baseline] (9.039 ms) : 0, 9039
Telemetry [candidate] (8.943 ms) : 0, 8943
Flare Poller [baseline] (3.8 ms) : 0, 3800
Flare Poller [candidate] (3.794 ms) : 0, 3794
section appsec
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (693.392 ms) : 0, 693392
BytebuddyAgent [candidate] (691.26 ms) : 0, 691260
GlobalTracer [baseline] (259.335 ms) : 0, 259335
GlobalTracer [candidate] (258.737 ms) : 0, 258737
AppSec [baseline] (173.375 ms) : 0, 173375
AppSec [candidate] (173.541 ms) : 0, 173541
Debugger [baseline] (67.637 ms) : 0, 67637
Debugger [candidate] (67.557 ms) : 0, 67557
Remote Config [baseline] (797.311 µs) : 0, 797
Remote Config [candidate] (779.809 µs) : 0, 780
Telemetry [baseline] (9.414 ms) : 0, 9414
Telemetry [candidate] (9.297 ms) : 0, 9297
Flare Poller [baseline] (3.732 ms) : 0, 3732
Flare Poller [candidate] (3.762 ms) : 0, 3762
IAST [baseline] (24.567 ms) : 0, 24567
IAST [candidate] (24.467 ms) : 0, 24467
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (798.356 ms) : 0, 798356
BytebuddyAgent [candidate] (792.31 ms) : 0, 792310
GlobalTracer [baseline] (258.904 ms) : 0, 258904
GlobalTracer [candidate] (257.199 ms) : 0, 257199
AppSec [baseline] (32.877 ms) : 0, 32877
AppSec [candidate] (35.147 ms) : 0, 35147
Debugger [baseline] (68.408 ms) : 0, 68408
Debugger [candidate] (65.015 ms) : 0, 65015
Remote Config [baseline] (589.812 µs) : 0, 590
Remote Config [candidate] (562.741 µs) : 0, 563
Telemetry [baseline] (8.528 ms) : 0, 8528
Telemetry [candidate] (8.424 ms) : 0, 8424
Flare Poller [baseline] (3.595 ms) : 0, 3595
Flare Poller [candidate] (3.546 ms) : 0, 3546
IAST [baseline] (27.242 ms) : 0, 27242
IAST [candidate] (27.022 ms) : 0, 27022
section profiling
ProfilingAgent [baseline] (97.895 ms) : 0, 97895
ProfilingAgent [candidate] (98.133 ms) : 0, 98133
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (707.0 ms) : 0, 707000
BytebuddyAgent [candidate] (708.77 ms) : 0, 708770
GlobalTracer [baseline] (222.426 ms) : 0, 222426
GlobalTracer [candidate] (222.931 ms) : 0, 222931
AppSec [baseline] (32.374 ms) : 0, 32374
AppSec [candidate] (32.567 ms) : 0, 32567
Debugger [baseline] (68.821 ms) : 0, 68821
Debugger [candidate] (68.848 ms) : 0, 68848
Remote Config [baseline] (664.287 µs) : 0, 664
Remote Config [candidate] (666.116 µs) : 0, 666
Telemetry [baseline] (9.156 ms) : 0, 9156
Telemetry [candidate] (9.055 ms) : 0, 9055
Flare Poller [baseline] (3.866 ms) : 0, 3866
Flare Poller [candidate] (3.793 ms) : 0, 3793
Profiling [baseline] (98.487 ms) : 0, 98487
Profiling [candidate] (98.713 ms) : 0, 98713
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~66d8189f0f, baseline=1.59.0-SNAPSHOT~291602a1aa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089304
Total [baseline] (8.772 s) : 0, 8771580
Agent [candidate] (1.087 s) : 0, 1086961
Total [candidate] (8.794 s) : 0, 8793789
section iast
Agent [baseline] (1.221 s) : 0, 1221207
Total [baseline] (9.305 s) : 0, 9305291
Agent [candidate] (1.227 s) : 0, 1227398
Total [candidate] (9.371 s) : 0, 9370777
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~66d8189f0f, baseline=1.59.0-SNAPSHOT~291602a1aa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (654.523 ms) : 0, 654523
BytebuddyAgent [candidate] (652.952 ms) : 0, 652952
GlobalTracer [baseline] (283.937 ms) : 0, 283937
GlobalTracer [candidate] (283.479 ms) : 0, 283479
AppSec [baseline] (33.017 ms) : 0, 33017
AppSec [candidate] (32.595 ms) : 0, 32595
Debugger [baseline] (67.633 ms) : 0, 67633
Debugger [candidate] (67.656 ms) : 0, 67656
Remote Config [baseline] (669.506 µs) : 0, 670
Remote Config [candidate] (620.39 µs) : 0, 620
Telemetry [baseline] (8.942 ms) : 0, 8942
Telemetry [candidate] (8.974 ms) : 0, 8974
Flare Poller [baseline] (3.753 ms) : 0, 3753
Flare Poller [candidate] (3.861 ms) : 0, 3861
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (789.894 ms) : 0, 789894
BytebuddyAgent [candidate] (793.371 ms) : 0, 793371
GlobalTracer [baseline] (256.5 ms) : 0, 256500
GlobalTracer [candidate] (257.478 ms) : 0, 257478
AppSec [baseline] (35.052 ms) : 0, 35052
AppSec [candidate] (35.477 ms) : 0, 35477
Debugger [baseline] (63.586 ms) : 0, 63586
Debugger [candidate] (64.549 ms) : 0, 64549
Remote Config [baseline] (570.471 µs) : 0, 570
Remote Config [candidate] (595.953 µs) : 0, 596
Telemetry [baseline] (8.43 ms) : 0, 8430
Telemetry [candidate] (8.645 ms) : 0, 8645
Flare Poller [baseline] (3.572 ms) : 0, 3572
Flare Poller [candidate] (3.637 ms) : 0, 3637
IAST [baseline] (26.905 ms) : 0, 26905
IAST [candidate] (26.928 ms) : 0, 26928
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~66d8189f0f, baseline=1.59.0-SNAPSHOT~291602a1aa
dateFormat X
axisFormat %s
section baseline
no_agent (1.177 ms) : 1166, 1189
. : milestone, 1177,
iast (3.186 ms) : 3142, 3230
. : milestone, 3186,
iast_FULL (5.788 ms) : 5730, 5846
. : milestone, 5788,
iast_GLOBAL (3.687 ms) : 3628, 3747
. : milestone, 3687,
profiling (2.015 ms) : 1996, 2034
. : milestone, 2015,
tracing (1.756 ms) : 1742, 1771
. : milestone, 1756,
section candidate
no_agent (1.166 ms) : 1155, 1177
. : milestone, 1166,
iast (3.212 ms) : 3168, 3257
. : milestone, 3212,
iast_FULL (5.724 ms) : 5667, 5781
. : milestone, 5724,
iast_GLOBAL (3.615 ms) : 3559, 3672
. : milestone, 3615,
profiling (2.126 ms) : 2107, 2145
. : milestone, 2126,
tracing (1.77 ms) : 1756, 1785
. : milestone, 1770,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~66d8189f0f, baseline=1.59.0-SNAPSHOT~291602a1aa
dateFormat X
axisFormat %s
section baseline
no_agent (17.888 ms) : 17707, 18070
. : milestone, 17888,
appsec (18.429 ms) : 18243, 18614
. : milestone, 18429,
code_origins (17.457 ms) : 17284, 17630
. : milestone, 17457,
iast (17.519 ms) : 17344, 17693
. : milestone, 17519,
profiling (18.953 ms) : 18762, 19143
. : milestone, 18953,
tracing (17.638 ms) : 17461, 17816
. : milestone, 17638,
section candidate
no_agent (17.754 ms) : 17574, 17934
. : milestone, 17754,
appsec (18.173 ms) : 17987, 18359
. : milestone, 18173,
code_origins (17.717 ms) : 17541, 17893
. : milestone, 17717,
iast (17.856 ms) : 17676, 18035
. : milestone, 17856,
profiling (18.829 ms) : 18636, 19022
. : milestone, 18829,
tracing (17.564 ms) : 17393, 17736
. : milestone, 17564,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~66d8189f0f, baseline=1.59.0-SNAPSHOT~291602a1aa
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (4.135 ms) : 3884, 4386
. : milestone, 4135,
iast (2.599 ms) : 2495, 2704
. : milestone, 2599,
iast_GLOBAL (2.65 ms) : 2545, 2755
. : milestone, 2650,
profiling (2.455 ms) : 2364, 2545
. : milestone, 2455,
tracing (2.395 ms) : 2309, 2481
. : milestone, 2395,
section candidate
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (4.237 ms) : 3981, 4494
. : milestone, 4237,
iast (2.607 ms) : 2503, 2711
. : milestone, 2607,
iast_GLOBAL (2.644 ms) : 2539, 2749
. : milestone, 2644,
profiling (2.426 ms) : 2337, 2515
. : milestone, 2426,
tracing (2.38 ms) : 2294, 2465
. : milestone, 2380,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~66d8189f0f, baseline=1.59.0-SNAPSHOT~291602a1aa
dateFormat X
axisFormat %s
section baseline
no_agent (14.784 s) : 14784000, 14784000
. : milestone, 14784000,
appsec (14.489 s) : 14489000, 14489000
. : milestone, 14489000,
iast (17.679 s) : 17679000, 17679000
. : milestone, 17679000,
iast_GLOBAL (17.392 s) : 17392000, 17392000
. : milestone, 17392000,
profiling (14.594 s) : 14594000, 14594000
. : milestone, 14594000,
tracing (14.415 s) : 14415000, 14415000
. : milestone, 14415000,
section candidate
no_agent (15.049 s) : 15049000, 15049000
. : milestone, 15049000,
appsec (14.617 s) : 14617000, 14617000
. : milestone, 14617000,
iast (17.837 s) : 17837000, 17837000
. : milestone, 17837000,
iast_GLOBAL (17.129 s) : 17129000, 17129000
. : milestone, 17129000,
profiling (14.178 s) : 14178000, 14178000
. : milestone, 14178000,
tracing (14.16 s) : 14160000, 14160000
. : milestone, 14160000,
|
285781e to
66d8189
Compare
AlexeyKuznetsov-DD
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: jetty
Jetty instrumentation
tag: no release notes
Changes to exclude from release notes
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Like #10355, #10365, servlet 3.x is leaking, this exclude the dependency. However this module's latest dependency is jersey 9.2, which supports servlet-api 3.
Given the rules of configurations, it's not possible to exclude on
testImplementation(the exclusion would propagate). So instead, we need to apply on the exclusion ontestRuntimeClasspath. And we explicitly addlatestDepTestImplementationthe servlet-api there.Motivation
Additional Notes