-
Notifications
You must be signed in to change notification settings - Fork 324
Better errors in vert-x-pg-client-4 tests #10361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~e9276be2cc, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086052
Total [baseline] (8.772 s) : 0, 8771614
Agent [candidate] (1.084 s) : 0, 1084290
Total [candidate] (8.786 s) : 0, 8785893
section iast
Agent [baseline] (1.235 s) : 0, 1235021
Total [baseline] (9.317 s) : 0, 9317362
Agent [candidate] (1.226 s) : 0, 1225513
Total [candidate] (9.316 s) : 0, 9316204
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~e9276be2cc, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (652.343 ms) : 0, 652343
BytebuddyAgent [candidate] (651.666 ms) : 0, 651666
GlobalTracer [baseline] (282.906 ms) : 0, 282906
GlobalTracer [candidate] (282.795 ms) : 0, 282795
AppSec [baseline] (32.671 ms) : 0, 32671
AppSec [candidate] (32.572 ms) : 0, 32572
Debugger [baseline] (67.912 ms) : 0, 67912
Debugger [candidate] (67.142 ms) : 0, 67142
Remote Config [baseline] (642.702 µs) : 0, 643
Remote Config [candidate] (632.028 µs) : 0, 632
Telemetry [baseline] (9.098 ms) : 0, 9098
Telemetry [candidate] (8.923 ms) : 0, 8923
Flare Poller [baseline] (3.865 ms) : 0, 3865
Flare Poller [candidate] (3.746 ms) : 0, 3746
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (798.175 ms) : 0, 798175
BytebuddyAgent [candidate] (792.423 ms) : 0, 792423
GlobalTracer [baseline] (259.222 ms) : 0, 259222
GlobalTracer [candidate] (257.016 ms) : 0, 257016
IAST [baseline] (27.427 ms) : 0, 27427
IAST [candidate] (27.173 ms) : 0, 27173
AppSec [baseline] (35.4 ms) : 0, 35400
AppSec [candidate] (34.274 ms) : 0, 34274
Debugger [baseline] (64.975 ms) : 0, 64975
Debugger [candidate] (65.119 ms) : 0, 65119
Remote Config [baseline] (585.328 µs) : 0, 585
Remote Config [candidate] (599.944 µs) : 0, 600
Telemetry [baseline] (8.697 ms) : 0, 8697
Telemetry [candidate] (8.596 ms) : 0, 8596
Flare Poller [baseline] (3.65 ms) : 0, 3650
Flare Poller [candidate] (3.637 ms) : 0, 3637
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~e9276be2cc, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085709
Total [baseline] (10.78 s) : 0, 10779561
Agent [candidate] (1.092 s) : 0, 1091755
Total [candidate] (10.906 s) : 0, 10905751
section appsec
Agent [baseline] (1.266 s) : 0, 1266041
Total [baseline] (11.067 s) : 0, 11067279
Agent [candidate] (1.269 s) : 0, 1268606
Total [candidate] (11.002 s) : 0, 11002106
section iast
Agent [baseline] (1.227 s) : 0, 1227354
Total [baseline] (11.247 s) : 0, 11246901
Agent [candidate] (1.234 s) : 0, 1233751
Total [candidate] (11.188 s) : 0, 11188059
section profiling
Agent [baseline] (1.214 s) : 0, 1213730
Total [baseline] (10.985 s) : 0, 10984615
Agent [candidate] (1.218 s) : 0, 1217599
Total [candidate] (10.983 s) : 0, 10982517
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~e9276be2cc, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (651.857 ms) : 0, 651857
BytebuddyAgent [candidate] (655.564 ms) : 0, 655564
GlobalTracer [baseline] (282.924 ms) : 0, 282924
GlobalTracer [candidate] (284.384 ms) : 0, 284384
AppSec [baseline] (32.719 ms) : 0, 32719
AppSec [candidate] (32.98 ms) : 0, 32980
Debugger [baseline] (68.049 ms) : 0, 68049
Debugger [candidate] (68.514 ms) : 0, 68514
Remote Config [baseline] (646.747 µs) : 0, 647
Remote Config [candidate] (644.868 µs) : 0, 645
Telemetry [baseline] (8.926 ms) : 0, 8926
Telemetry [candidate] (9.035 ms) : 0, 9035
Flare Poller [baseline] (3.769 ms) : 0, 3769
Flare Poller [candidate] (3.838 ms) : 0, 3838
section appsec
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (691.055 ms) : 0, 691055
BytebuddyAgent [candidate] (694.048 ms) : 0, 694048
GlobalTracer [baseline] (258.987 ms) : 0, 258987
GlobalTracer [candidate] (258.912 ms) : 0, 258912
AppSec [baseline] (174.034 ms) : 0, 174034
AppSec [candidate] (174.421 ms) : 0, 174421
Debugger [baseline] (66.877 ms) : 0, 66877
Debugger [candidate] (65.813 ms) : 0, 65813
Remote Config [baseline] (757.603 µs) : 0, 758
Remote Config [candidate] (791.465 µs) : 0, 791
Telemetry [baseline] (9.307 ms) : 0, 9307
Telemetry [candidate] (9.28 ms) : 0, 9280
Flare Poller [baseline] (3.749 ms) : 0, 3749
Flare Poller [candidate] (3.674 ms) : 0, 3674
IAST [baseline] (24.611 ms) : 0, 24611
IAST [candidate] (24.943 ms) : 0, 24943
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (793.317 ms) : 0, 793317
BytebuddyAgent [candidate] (798.04 ms) : 0, 798040
GlobalTracer [baseline] (257.023 ms) : 0, 257023
GlobalTracer [candidate] (258.219 ms) : 0, 258219
AppSec [baseline] (35.216 ms) : 0, 35216
AppSec [candidate] (33.613 ms) : 0, 33613
Debugger [baseline] (65.119 ms) : 0, 65119
Debugger [candidate] (67.02 ms) : 0, 67020
Remote Config [baseline] (599.009 µs) : 0, 599
Remote Config [candidate] (581.919 µs) : 0, 582
Telemetry [baseline] (8.61 ms) : 0, 8610
Telemetry [candidate] (8.575 ms) : 0, 8575
Flare Poller [baseline] (3.585 ms) : 0, 3585
Flare Poller [candidate] (3.591 ms) : 0, 3591
IAST [baseline] (27.193 ms) : 0, 27193
IAST [candidate] (27.098 ms) : 0, 27098
section profiling
ProfilingAgent [baseline] (97.612 ms) : 0, 97612
ProfilingAgent [candidate] (97.214 ms) : 0, 97214
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.232 ms) : 0, 1232
BytebuddyAgent [baseline] (707.29 ms) : 0, 707290
BytebuddyAgent [candidate] (710.227 ms) : 0, 710227
GlobalTracer [baseline] (222.678 ms) : 0, 222678
GlobalTracer [candidate] (223.212 ms) : 0, 223212
AppSec [baseline] (32.46 ms) : 0, 32460
AppSec [candidate] (32.571 ms) : 0, 32571
Debugger [baseline] (68.657 ms) : 0, 68657
Debugger [candidate] (69.175 ms) : 0, 69175
Remote Config [baseline] (662.794 µs) : 0, 663
Remote Config [candidate] (631.538 µs) : 0, 632
Telemetry [baseline] (8.976 ms) : 0, 8976
Telemetry [candidate] (9.025 ms) : 0, 9025
Flare Poller [baseline] (3.784 ms) : 0, 3784
Flare Poller [candidate] (3.791 ms) : 0, 3791
Profiling [baseline] (98.196 ms) : 0, 98196
Profiling [candidate] (97.806 ms) : 0, 97806
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~e9276be2cc, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section baseline
no_agent (1.247 ms) : 1235, 1260
. : milestone, 1247,
iast (3.262 ms) : 3214, 3310
. : milestone, 3262,
iast_FULL (5.874 ms) : 5815, 5933
. : milestone, 5874,
iast_GLOBAL (3.662 ms) : 3608, 3716
. : milestone, 3662,
profiling (1.969 ms) : 1953, 1985
. : milestone, 1969,
tracing (1.779 ms) : 1764, 1794
. : milestone, 1779,
section candidate
no_agent (1.201 ms) : 1189, 1213
. : milestone, 1201,
iast (3.199 ms) : 3158, 3241
. : milestone, 3199,
iast_FULL (5.712 ms) : 5655, 5769
. : milestone, 5712,
iast_GLOBAL (3.612 ms) : 3552, 3672
. : milestone, 3612,
profiling (2.02 ms) : 2001, 2038
. : milestone, 2020,
tracing (1.858 ms) : 1842, 1873
. : milestone, 1858,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~e9276be2cc, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section baseline
no_agent (17.109 ms) : 16939, 17280
. : milestone, 17109,
appsec (18.856 ms) : 18665, 19046
. : milestone, 18856,
code_origins (17.621 ms) : 17448, 17795
. : milestone, 17621,
iast (17.996 ms) : 17814, 18178
. : milestone, 17996,
profiling (20.864 ms) : 20655, 21074
. : milestone, 20864,
tracing (18.782 ms) : 18589, 18975
. : milestone, 18782,
section candidate
no_agent (18.056 ms) : 17873, 18239
. : milestone, 18056,
appsec (18.662 ms) : 18472, 18852
. : milestone, 18662,
code_origins (18.14 ms) : 17956, 18323
. : milestone, 18140,
iast (19.186 ms) : 18989, 19383
. : milestone, 19186,
profiling (18.962 ms) : 18775, 19148
. : milestone, 18962,
tracing (17.81 ms) : 17634, 17987
. : milestone, 17810,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~e9276be2cc, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1485
. : milestone, 1473,
appsec (3.673 ms) : 3458, 3888
. : milestone, 3673,
iast (2.216 ms) : 2151, 2281
. : milestone, 2216,
iast_GLOBAL (2.255 ms) : 2190, 2321
. : milestone, 2255,
profiling (2.085 ms) : 2031, 2139
. : milestone, 2085,
tracing (2.055 ms) : 2003, 2107
. : milestone, 2055,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.67 ms) : 3454, 3886
. : milestone, 3670,
iast (2.22 ms) : 2155, 2285
. : milestone, 2220,
iast_GLOBAL (2.26 ms) : 2194, 2326
. : milestone, 2260,
profiling (2.053 ms) : 2001, 2106
. : milestone, 2053,
tracing (2.056 ms) : 2004, 2109
. : milestone, 2056,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~e9276be2cc, baseline=1.59.0-SNAPSHOT~671cc8cdbf
dateFormat X
axisFormat %s
section baseline
no_agent (14.962 s) : 14962000, 14962000
. : milestone, 14962000,
appsec (14.57 s) : 14570000, 14570000
. : milestone, 14570000,
iast (17.803 s) : 17803000, 17803000
. : milestone, 17803000,
iast_GLOBAL (17.71 s) : 17710000, 17710000
. : milestone, 17710000,
profiling (15.198 s) : 15198000, 15198000
. : milestone, 15198000,
tracing (14.893 s) : 14893000, 14893000
. : milestone, 14893000,
section candidate
no_agent (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
appsec (14.476 s) : 14476000, 14476000
. : milestone, 14476000,
iast (17.854 s) : 17854000, 17854000
. : milestone, 17854000,
iast_GLOBAL (17.616 s) : 17616000, 17616000
. : milestone, 17616000,
profiling (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
tracing (14.741 s) : 14741000, 14741000
. : milestone, 14741000,
|
vandonr
commented
Jan 14, 2026
internal-api/src/test/groovy/datadog/trace/api/debugger/DebuggerConfigBridgeTest.groovy
Show resolved
Hide resolved
amarziali
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: testing
Testing
inst: vertx
Eclipse Vert.x instrumentation
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
We were getting the result of the async call blindly, which resulted in a nullref further down the way when the call failed, which was not very helpful.
Capturing the async result entirely allows us to catch the error on the spot, and display the cause.
Motivation
this happened when latest dep tests broke.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]