-
Notifications
You must be signed in to change notification settings - Fork 324
Add early Tracing assert rules for Java based instrumentation tests #10257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
PerfectSlayer
wants to merge
5
commits into
master
Choose a base branch
from
bbujon/virtual-threads
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~2f86d9b3ec, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086272
Total [baseline] (8.776 s) : 0, 8776045
Agent [candidate] (1.093 s) : 0, 1092681
Total [candidate] (8.791 s) : 0, 8790807
section iast
Agent [baseline] (1.231 s) : 0, 1231249
Total [baseline] (9.332 s) : 0, 9332293
Agent [candidate] (1.224 s) : 0, 1223785
Total [candidate] (9.321 s) : 0, 9320573
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~2f86d9b3ec, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (652.821 ms) : 0, 652821
BytebuddyAgent [candidate] (656.94 ms) : 0, 656940
GlobalTracer [baseline] (283.547 ms) : 0, 283547
GlobalTracer [candidate] (284.883 ms) : 0, 284883
AppSec [baseline] (32.785 ms) : 0, 32785
AppSec [candidate] (33.118 ms) : 0, 33118
Debugger [baseline] (67.002 ms) : 0, 67002
Debugger [candidate] (67.578 ms) : 0, 67578
Remote Config [baseline] (658.418 µs) : 0, 658
Remote Config [candidate] (655.954 µs) : 0, 656
Telemetry [baseline] (8.979 ms) : 0, 8979
Telemetry [candidate] (8.926 ms) : 0, 8926
Flare Poller [baseline] (3.823 ms) : 0, 3823
Flare Poller [candidate] (3.781 ms) : 0, 3781
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (797.956 ms) : 0, 797956
BytebuddyAgent [candidate] (791.983 ms) : 0, 791983
GlobalTracer [baseline] (257.357 ms) : 0, 257357
GlobalTracer [candidate] (256.536 ms) : 0, 256536
IAST [baseline] (27.262 ms) : 0, 27262
IAST [candidate] (27.027 ms) : 0, 27027
AppSec [baseline] (35.326 ms) : 0, 35326
AppSec [candidate] (34.154 ms) : 0, 34154
Debugger [baseline] (63.823 ms) : 0, 63823
Debugger [candidate] (64.847 ms) : 0, 64847
Remote Config [baseline] (602.87 µs) : 0, 603
Remote Config [candidate] (619.83 µs) : 0, 620
Telemetry [baseline] (8.567 ms) : 0, 8567
Telemetry [candidate] (8.417 ms) : 0, 8417
Flare Poller [baseline] (3.578 ms) : 0, 3578
Flare Poller [candidate] (3.606 ms) : 0, 3606
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~2f86d9b3ec, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1092547
Total [baseline] (10.755 s) : 0, 10755490
Agent [candidate] (1.087 s) : 0, 1087230
Total [candidate] (10.802 s) : 0, 10802331
section appsec
Agent [baseline] (1.275 s) : 0, 1275227
Total [baseline] (11.004 s) : 0, 11004422
Agent [candidate] (1.27 s) : 0, 1269715
Total [candidate] (11.022 s) : 0, 11021565
section iast
Agent [baseline] (1.226 s) : 0, 1225649
Total [baseline] (11.194 s) : 0, 11193914
Agent [candidate] (1.236 s) : 0, 1235704
Total [candidate] (11.262 s) : 0, 11262418
section profiling
Agent [baseline] (1.204 s) : 0, 1203941
Total [baseline] (10.951 s) : 0, 10950575
Agent [candidate] (1.205 s) : 0, 1204782
Total [candidate] (10.87 s) : 0, 10869836
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~2f86d9b3ec, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (655.987 ms) : 0, 655987
BytebuddyAgent [candidate] (653.017 ms) : 0, 653017
GlobalTracer [baseline] (284.813 ms) : 0, 284813
GlobalTracer [candidate] (283.443 ms) : 0, 283443
AppSec [baseline] (32.958 ms) : 0, 32958
AppSec [candidate] (32.66 ms) : 0, 32660
Debugger [baseline] (68.461 ms) : 0, 68461
Debugger [candidate] (67.931 ms) : 0, 67931
Remote Config [baseline] (633.502 µs) : 0, 634
Remote Config [candidate] (648.769 µs) : 0, 649
Telemetry [baseline] (8.918 ms) : 0, 8918
Telemetry [candidate] (8.992 ms) : 0, 8992
Flare Poller [baseline] (3.794 ms) : 0, 3794
Flare Poller [candidate] (3.771 ms) : 0, 3771
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (696.723 ms) : 0, 696723
BytebuddyAgent [candidate] (693.218 ms) : 0, 693218
GlobalTracer [baseline] (260.872 ms) : 0, 260872
GlobalTracer [candidate] (260.008 ms) : 0, 260008
AppSec [baseline] (172.742 ms) : 0, 172742
AppSec [candidate] (172.055 ms) : 0, 172055
Debugger [baseline] (69.023 ms) : 0, 69023
Debugger [candidate] (69.126 ms) : 0, 69126
Remote Config [baseline] (771.446 µs) : 0, 771
Remote Config [candidate] (751.496 µs) : 0, 751
Telemetry [baseline] (9.329 ms) : 0, 9329
Telemetry [candidate] (9.394 ms) : 0, 9394
Flare Poller [baseline] (3.818 ms) : 0, 3818
Flare Poller [candidate] (3.77 ms) : 0, 3770
IAST [baseline] (25.18 ms) : 0, 25180
IAST [candidate] (24.671 ms) : 0, 24671
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (793.281 ms) : 0, 793281
BytebuddyAgent [candidate] (799.38 ms) : 0, 799380
GlobalTracer [baseline] (256.555 ms) : 0, 256555
GlobalTracer [candidate] (258.937 ms) : 0, 258937
AppSec [baseline] (32.533 ms) : 0, 32533
AppSec [candidate] (34.617 ms) : 0, 34617
Debugger [baseline] (67.168 ms) : 0, 67168
Debugger [candidate] (65.91 ms) : 0, 65910
Remote Config [baseline] (553.6 µs) : 0, 554
Remote Config [candidate] (581.675 µs) : 0, 582
Telemetry [baseline] (8.448 ms) : 0, 8448
Telemetry [candidate] (8.505 ms) : 0, 8505
Flare Poller [baseline] (3.542 ms) : 0, 3542
Flare Poller [candidate] (3.647 ms) : 0, 3647
IAST [baseline] (27.041 ms) : 0, 27041
IAST [candidate] (27.373 ms) : 0, 27373
section profiling
ProfilingAgent [baseline] (97.451 ms) : 0, 97451
ProfilingAgent [candidate] (97.164 ms) : 0, 97164
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (700.564 ms) : 0, 700564
BytebuddyAgent [candidate] (702.319 ms) : 0, 702319
GlobalTracer [baseline] (220.308 ms) : 0, 220308
GlobalTracer [candidate] (220.835 ms) : 0, 220835
AppSec [baseline] (32.287 ms) : 0, 32287
AppSec [candidate] (32.251 ms) : 0, 32251
Debugger [baseline] (68.949 ms) : 0, 68949
Debugger [candidate] (67.943 ms) : 0, 67943
Remote Config [baseline] (663.344 µs) : 0, 663
Remote Config [candidate] (638.69 µs) : 0, 639
Telemetry [baseline] (9.062 ms) : 0, 9062
Telemetry [candidate] (8.914 ms) : 0, 8914
Flare Poller [baseline] (3.744 ms) : 0, 3744
Flare Poller [candidate] (3.755 ms) : 0, 3755
Profiling [baseline] (98.038 ms) : 0, 98038
Profiling [candidate] (97.735 ms) : 0, 97735
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~2f86d9b3ec, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section baseline
no_agent (18.06 ms) : 17873, 18247
. : milestone, 18060,
appsec (19.624 ms) : 19421, 19828
. : milestone, 19624,
code_origins (17.667 ms) : 17488, 17846
. : milestone, 17667,
iast (17.655 ms) : 17479, 17832
. : milestone, 17655,
profiling (18.764 ms) : 18579, 18950
. : milestone, 18764,
tracing (17.664 ms) : 17487, 17841
. : milestone, 17664,
section candidate
no_agent (19.088 ms) : 18889, 19286
. : milestone, 19088,
appsec (18.562 ms) : 18375, 18749
. : milestone, 18562,
code_origins (17.838 ms) : 17660, 18016
. : milestone, 17838,
iast (17.72 ms) : 17543, 17897
. : milestone, 17720,
profiling (18.727 ms) : 18540, 18915
. : milestone, 18727,
tracing (17.661 ms) : 17485, 17837
. : milestone, 17661,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~2f86d9b3ec, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section baseline
no_agent (1.176 ms) : 1164, 1187
. : milestone, 1176,
iast (3.124 ms) : 3083, 3165
. : milestone, 3124,
iast_FULL (5.742 ms) : 5684, 5800
. : milestone, 5742,
iast_GLOBAL (3.557 ms) : 3499, 3615
. : milestone, 3557,
profiling (1.981 ms) : 1964, 1998
. : milestone, 1981,
tracing (1.793 ms) : 1778, 1807
. : milestone, 1793,
section candidate
no_agent (1.17 ms) : 1158, 1181
. : milestone, 1170,
iast (3.229 ms) : 3184, 3274
. : milestone, 3229,
iast_FULL (5.679 ms) : 5622, 5735
. : milestone, 5679,
iast_GLOBAL (3.425 ms) : 3378, 3471
. : milestone, 3425,
profiling (1.887 ms) : 1871, 1903
. : milestone, 1887,
tracing (1.859 ms) : 1842, 1876
. : milestone, 1859,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~2f86d9b3ec, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.747 ms) : 3523, 3972
. : milestone, 3747,
iast (2.216 ms) : 2151, 2282
. : milestone, 2216,
iast_GLOBAL (2.259 ms) : 2194, 2325
. : milestone, 2259,
profiling (2.071 ms) : 2018, 2124
. : milestone, 2071,
tracing (2.062 ms) : 2011, 2114
. : milestone, 2062,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.736 ms) : 3516, 3956
. : milestone, 3736,
iast (2.214 ms) : 2149, 2279
. : milestone, 2214,
iast_GLOBAL (2.264 ms) : 2199, 2330
. : milestone, 2264,
profiling (2.076 ms) : 2023, 2129
. : milestone, 2076,
tracing (2.058 ms) : 2007, 2110
. : milestone, 2058,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~2f86d9b3ec, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section baseline
no_agent (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
appsec (14.67 s) : 14670000, 14670000
. : milestone, 14670000,
iast (18.379 s) : 18379000, 18379000
. : milestone, 18379000,
iast_GLOBAL (17.8 s) : 17800000, 17800000
. : milestone, 17800000,
profiling (14.546 s) : 14546000, 14546000
. : milestone, 14546000,
tracing (14.649 s) : 14649000, 14649000
. : milestone, 14649000,
section candidate
no_agent (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
appsec (14.919 s) : 14919000, 14919000
. : milestone, 14919000,
iast (18.157 s) : 18157000, 18157000
. : milestone, 18157000,
iast_GLOBAL (17.86 s) : 17860000, 17860000
. : milestone, 17860000,
profiling (14.652 s) : 14652000, 14652000
. : milestone, 14652000,
tracing (14.683 s) : 14683000, 14683000
. : milestone, 14683000,
|
dccd70a to
ed582d5
Compare
06ed437 to
2f86d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR shares the current progress of Java-based instrumentation tests.
In addition to the experimental test class, it brings JUnit assert rules to assert traces and spans.
Those API are still experimental and will be completed and refined a near feature.
Motivation
Sharing the progress to prevent code publication and get early feedback.
As this development will be put in halt for this quarter, sharing its current state will avoid it to go into limbo.
It's fairly isolated so it should not impact the rest of the codebase meanwhile.
Additional Notes
Based on my 2024Q4 R&D week research.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]