-
Notifications
You must be signed in to change notification settings - Fork 324
Enable merge queue #10002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enable merge queue #10002
Conversation
Would there be a way for benchmarks to excluded on purpose rather than opt-in? I guess big regression would catch most of the issues, but I would think that casual offenders introduce regression because their don't know about it, so they would not opt into benchmarks in the first place? |
@PerfectSlayer Yes we can also do that! Perhaps we could run a longer, more stable benchmark in the merge queue and still have some benchmarks run on every push 🤔
Agreed! I'll wait for a Guild discussion before proceeding any further |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 3 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~1fd83812e1, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087932
Total [baseline] (8.786 s) : 0, 8786222
Agent [candidate] (1.09 s) : 0, 1089638
Total [candidate] (8.738 s) : 0, 8738168
section iast
Agent [baseline] (1.235 s) : 0, 1235431
Total [baseline] (9.319 s) : 0, 9319040
Agent [candidate] (1.236 s) : 0, 1235881
Total [candidate] (9.281 s) : 0, 9280740
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~1fd83812e1, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (651.955 ms) : 0, 651955
BytebuddyAgent [candidate] (652.886 ms) : 0, 652886
GlobalTracer [baseline] (285.782 ms) : 0, 285782
GlobalTracer [candidate] (286.74 ms) : 0, 286740
AppSec [baseline] (33.03 ms) : 0, 33030
AppSec [candidate] (32.794 ms) : 0, 32794
Debugger [baseline] (67.155 ms) : 0, 67155
Debugger [candidate] (66.521 ms) : 0, 66521
Remote Config [baseline] (613.408 µs) : 0, 613
Remote Config [candidate] (607.4 µs) : 0, 607
Telemetry [baseline] (8.952 ms) : 0, 8952
Telemetry [candidate] (8.924 ms) : 0, 8924
Flare Poller [baseline] (3.751 ms) : 0, 3751
Flare Poller [candidate] (4.502 ms) : 0, 4502
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (798.388 ms) : 0, 798388
BytebuddyAgent [candidate] (800.127 ms) : 0, 800127
GlobalTracer [baseline] (260.421 ms) : 0, 260421
GlobalTracer [candidate] (260.007 ms) : 0, 260007
IAST [baseline] (27.242 ms) : 0, 27242
IAST [candidate] (27.078 ms) : 0, 27078
AppSec [baseline] (35.414 ms) : 0, 35414
AppSec [candidate] (34.22 ms) : 0, 34220
Debugger [baseline] (64.595 ms) : 0, 64595
Debugger [candidate] (65.294 ms) : 0, 65294
Remote Config [baseline] (544.787 µs) : 0, 545
Remote Config [candidate] (533.077 µs) : 0, 533
Telemetry [baseline] (8.577 ms) : 0, 8577
Telemetry [candidate] (8.453 ms) : 0, 8453
Flare Poller [baseline] (3.522 ms) : 0, 3522
Flare Poller [candidate] (3.444 ms) : 0, 3444
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~1fd83812e1, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089534
Total [baseline] (10.761 s) : 0, 10760647
Agent [candidate] (1.09 s) : 0, 1089925
Total [candidate] (10.793 s) : 0, 10792891
section appsec
Agent [baseline] (1.269 s) : 0, 1268710
Total [baseline] (11.014 s) : 0, 11013757
Agent [candidate] (1.271 s) : 0, 1271008
Total [candidate] (11.084 s) : 0, 11083904
section iast
Agent [baseline] (1.23 s) : 0, 1229846
Total [baseline] (11.188 s) : 0, 11187686
Agent [candidate] (1.226 s) : 0, 1225926
Total [candidate] (11.131 s) : 0, 11130613
section profiling
Agent [baseline] (1.205 s) : 0, 1205126
Total [baseline] (10.856 s) : 0, 10856132
Agent [candidate] (1.204 s) : 0, 1204492
Total [candidate] (10.905 s) : 0, 10904903
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~1fd83812e1, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.168 ms) : 0, 1168
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (652.489 ms) : 0, 652489
BytebuddyAgent [candidate] (653.46 ms) : 0, 653460
GlobalTracer [baseline] (286.315 ms) : 0, 286315
GlobalTracer [candidate] (286.025 ms) : 0, 286025
AppSec [baseline] (33.057 ms) : 0, 33057
AppSec [candidate] (32.729 ms) : 0, 32729
Debugger [baseline] (67.883 ms) : 0, 67883
Debugger [candidate] (66.93 ms) : 0, 66930
Remote Config [baseline] (596.583 µs) : 0, 597
Remote Config [candidate] (599.161 µs) : 0, 599
Telemetry [baseline] (8.849 ms) : 0, 8849
Telemetry [candidate] (8.896 ms) : 0, 8896
Flare Poller [baseline] (3.746 ms) : 0, 3746
Flare Poller [candidate] (4.535 ms) : 0, 4535
section appsec
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (691.352 ms) : 0, 691352
BytebuddyAgent [candidate] (692.576 ms) : 0, 692576
GlobalTracer [baseline] (262.234 ms) : 0, 262234
GlobalTracer [candidate] (262.786 ms) : 0, 262786
IAST [baseline] (24.759 ms) : 0, 24759
IAST [candidate] (24.931 ms) : 0, 24931
AppSec [baseline] (174.071 ms) : 0, 174071
AppSec [candidate] (173.05 ms) : 0, 173050
Debugger [baseline] (65.975 ms) : 0, 65975
Debugger [candidate] (67.223 ms) : 0, 67223
Remote Config [baseline] (696.994 µs) : 0, 697
Remote Config [candidate] (684.314 µs) : 0, 684
Telemetry [baseline] (9.38 ms) : 0, 9380
Telemetry [candidate] (9.429 ms) : 0, 9429
Flare Poller [baseline] (3.689 ms) : 0, 3689
Flare Poller [candidate] (3.727 ms) : 0, 3727
section iast
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.167 ms) : 0, 1167
BytebuddyAgent [baseline] (793.78 ms) : 0, 793780
BytebuddyAgent [candidate] (790.931 ms) : 0, 790931
GlobalTracer [baseline] (259.529 ms) : 0, 259529
GlobalTracer [candidate] (258.564 ms) : 0, 258564
IAST [baseline] (27.038 ms) : 0, 27038
IAST [candidate] (26.873 ms) : 0, 26873
AppSec [baseline] (33.422 ms) : 0, 33422
AppSec [candidate] (34.453 ms) : 0, 34453
Debugger [baseline] (67.073 ms) : 0, 67073
Debugger [candidate] (66.053 ms) : 0, 66053
Remote Config [baseline] (545.119 µs) : 0, 545
Remote Config [candidate] (555.975 µs) : 0, 556
Telemetry [baseline] (8.486 ms) : 0, 8486
Telemetry [candidate] (8.532 ms) : 0, 8532
Flare Poller [baseline] (3.436 ms) : 0, 3436
Flare Poller [candidate] (3.499 ms) : 0, 3499
section profiling
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (700.302 ms) : 0, 700302
BytebuddyAgent [candidate] (700.36 ms) : 0, 700360
GlobalTracer [baseline] (224.199 ms) : 0, 224199
GlobalTracer [candidate] (224.46 ms) : 0, 224460
AppSec [baseline] (32.28 ms) : 0, 32280
AppSec [candidate] (32.329 ms) : 0, 32329
Debugger [baseline] (67.9 ms) : 0, 67900
Debugger [candidate] (67.46 ms) : 0, 67460
Remote Config [baseline] (607.163 µs) : 0, 607
Remote Config [candidate] (604.903 µs) : 0, 605
Telemetry [baseline] (8.78 ms) : 0, 8780
Telemetry [candidate] (8.775 ms) : 0, 8775
Flare Poller [baseline] (3.651 ms) : 0, 3651
Flare Poller [candidate] (3.571 ms) : 0, 3571
ProfilingAgent [baseline] (96.432 ms) : 0, 96432
ProfilingAgent [candidate] (96.059 ms) : 0, 96059
Profiling [baseline] (97.019 ms) : 0, 97019
Profiling [candidate] (96.632 ms) : 0, 96632
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~1fd83812e1, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.199 ms) : 1187, 1211
. : milestone, 1199,
iast (3.133 ms) : 3092, 3174
. : milestone, 3133,
iast_FULL (5.727 ms) : 5670, 5784
. : milestone, 5727,
iast_GLOBAL (3.601 ms) : 3541, 3661
. : milestone, 3601,
profiling (2.107 ms) : 2086, 2127
. : milestone, 2107,
tracing (1.847 ms) : 1831, 1863
. : milestone, 1847,
section candidate
no_agent (1.184 ms) : 1172, 1195
. : milestone, 1184,
iast (3.303 ms) : 3257, 3348
. : milestone, 3303,
iast_FULL (5.991 ms) : 5929, 6052
. : milestone, 5991,
iast_GLOBAL (3.591 ms) : 3541, 3640
. : milestone, 3591,
profiling (1.96 ms) : 1943, 1977
. : milestone, 1960,
tracing (1.814 ms) : 1798, 1829
. : milestone, 1814,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~1fd83812e1, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section baseline
no_agent (17.909 ms) : 17731, 18088
. : milestone, 17909,
appsec (18.987 ms) : 18799, 19175
. : milestone, 18987,
code_origins (18.542 ms) : 18354, 18730
. : milestone, 18542,
iast (17.79 ms) : 17612, 17969
. : milestone, 17790,
profiling (18.772 ms) : 18583, 18962
. : milestone, 18772,
tracing (17.667 ms) : 17492, 17841
. : milestone, 17667,
section candidate
no_agent (19.0 ms) : 18813, 19187
. : milestone, 19000,
appsec (18.732 ms) : 18547, 18917
. : milestone, 18732,
code_origins (17.569 ms) : 17396, 17743
. : milestone, 17569,
iast (17.646 ms) : 17468, 17824
. : milestone, 17646,
profiling (18.78 ms) : 18591, 18970
. : milestone, 18780,
tracing (17.585 ms) : 17410, 17759
. : milestone, 17585,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~1fd83812e1, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.667 ms) : 3452, 3882
. : milestone, 3667,
iast (2.212 ms) : 2148, 2277
. : milestone, 2212,
iast_GLOBAL (2.247 ms) : 2181, 2312
. : milestone, 2247,
profiling (2.064 ms) : 2012, 2117
. : milestone, 2064,
tracing (2.044 ms) : 1992, 2095
. : milestone, 2044,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.465 ms) : 2413, 2518
. : milestone, 2465,
iast (2.209 ms) : 2144, 2274
. : milestone, 2209,
iast_GLOBAL (2.248 ms) : 2183, 2313
. : milestone, 2248,
profiling (2.08 ms) : 2025, 2134
. : milestone, 2080,
tracing (2.05 ms) : 1999, 2102
. : milestone, 2050,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~1fd83812e1, baseline=1.59.0-SNAPSHOT~c6c245fe4a
dateFormat X
axisFormat %s
section baseline
no_agent (14.982 s) : 14982000, 14982000
. : milestone, 14982000,
appsec (14.607 s) : 14607000, 14607000
. : milestone, 14607000,
iast (18.087 s) : 18087000, 18087000
. : milestone, 18087000,
iast_GLOBAL (17.871 s) : 17871000, 17871000
. : milestone, 17871000,
profiling (14.741 s) : 14741000, 14741000
. : milestone, 14741000,
tracing (14.596 s) : 14596000, 14596000
. : milestone, 14596000,
section candidate
no_agent (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
appsec (14.495 s) : 14495000, 14495000
. : milestone, 14495000,
iast (18.03 s) : 18030000, 18030000
. : milestone, 18030000,
iast_GLOBAL (18.026 s) : 18026000, 18026000
. : milestone, 18026000,
profiling (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
tracing (14.733 s) : 14733000, 14733000
. : milestone, 14733000,
|
|
@sarahchen6 Do we need doggo in the browser ? I disabled it, just too many things not working ? |
What Does This Do
Enable a merge queue, and include the following configurations:
squashmethodmaster, but require a reason for skipping these checksMotivation
By enabling a merge queue, not only can we ensure that PRs pass CI with the latest version of
master, including all PRs merged before it, but also we can run certain checks (e.g. benchmarks) only when merging tomaster. Merge queues by default run with the "speculative" workflow type. More details here, but TLDR; each PR needs to pass with the latest version ofmaster+ any PRs that sit before it in the merge queue before being merged.For now, we will start by enabling just the merge queue, keeping all PR checks as-is. If this is successful, we can start tailoring merge queue-specific checks.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]