RUM-16325 timeseries: Post-review fixes for timeseries#3556
Merged
satween merged 1 commit intoJun 23, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
timeseries: Post-review fixes for timeseries
4c45d0d to
379720c
Compare
474fa4a to
1cfa953
Compare
379720c to
0419b26
Compare
1cfa953 to
61f8681
Compare
0419b26 to
5c8c3b4
Compare
61f8681 to
7ab7c75
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/timeseries #3556 +/- ##
======================================================
+ Coverage 72.60% 72.61% +0.01%
======================================================
Files 980 980
Lines 36053 36058 +5
Branches 6033 6031 -2
======================================================
+ Hits 26174 26182 +8
Misses 8198 8198
+ Partials 1681 1678 -3
🚀 New features to boost your workflow:
|
0xnm
previously approved these changes
Jun 19, 2026
5c8c3b4 to
41ecfd9
Compare
7ab7c75 to
46addf4
Compare
41ecfd9 to
147653a
Compare
d87694f to
b4386f7
Compare
Base automatically changed from
tvaleev/feature/timeseries-RUM-16325-schema-update
to
feature/timeseries
June 22, 2026 08:43
hamorillo
previously approved these changes
Jun 22, 2026
hamorillo
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
nit: Not related to this PR but as you are modifying this file maybe you can add the @Test missing in line:
b4386f7 to
34c8284
Compare
hamorillo
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Applies post-review fixes from PR on top of the schema update: adjustments to
RumFeature,RumSessionScope,TimeseriesConfiguration, and the CPU/Memory event serializers, plus added/updated unit and end-to-end tests.Review checklist (to be filled by reviewers)