Skip to content

[CTM-320] Updating angular 14 --> 19#804

Merged
lucymcnatt merged 35 commits intomasterfrom
CTM-320-updates
Mar 17, 2026
Merged

[CTM-320] Updating angular 14 --> 19#804
lucymcnatt merged 35 commits intomasterfrom
CTM-320-updates

Conversation

@lucymcnatt
Copy link
Copy Markdown
Collaborator

@lucymcnatt lucymcnatt commented Mar 6, 2026

https://broadworkbench.atlassian.net/browse/CTM-320

Security update, ran ng update for each major version and had to do some cleanup for deprecations, then had to update the styling (with claude help)

Screenshot 2026-03-17 at 10 57 29 AM Screenshot 2026-03-17 at 10 57 35 AM

Copy link
Copy Markdown
Collaborator

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be That Guy, but I'm seeing that 19 stops getting security updates on May 19.

It's not really a big deal as we can simply upgrade to ≥20 if we get a security ticket in the future. But it may be more efficient to get all the major version upgrades out of the way now and then coast.

Copy link
Copy Markdown
Collaborator

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good pending one issue, log files.

@@ -0,0 +1,542 @@
- Generating browser application bundles (phase: setup)...
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the other *.log file(s) do not seem like they should be checked in.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yup I'll remove that

Run the following command to upgrade to Angular 19 (change versions as needed):
`ng update @angular/core@15 @angular/cli@15`

This guide will also show a more in-depth list of changes to make when upgrading Angular versions: https://angular.dev/update-guide?v=14.0-19.0&l=2
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

"options": {
"main": "src/test.ts",
"polyfills": "src/polyfills.ts",
"polyfills": ["src/polyfills.ts"],
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what they were thinking before, having "polyfills" plural be a single value?

@lucymcnatt
Copy link
Copy Markdown
Collaborator Author

Sorry to be That Guy, but I'm seeing that 19 stops getting security updates on May 19.

I'll try updating to 20 and if it's not much additional effort, we might as well

@lucymcnatt
Copy link
Copy Markdown
Collaborator Author

Ok so Clarity (pretty widely used package) doesn't support angular 20 yet, so I'm gonna stick with 19 for now: https://clarity.design/pages/support-policies

@aednichols
Copy link
Copy Markdown
Collaborator

Seems reasonable to me! I will be happy to approve once the log files go.

Copy link
Copy Markdown
Collaborator

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thank you!

Copy link
Copy Markdown
Collaborator

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working through this gnarly update!

@lucymcnatt lucymcnatt merged commit ae76ef8 into master Mar 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants