[CTM-320] Updating angular 14 --> 19#804
Conversation
aednichols
left a comment
There was a problem hiding this comment.
Sorry to be That Guy, but I'm seeing that 19 stops getting security updates on May 19.
It's not really a big deal as we can simply upgrade to ≥20 if we get a security ticket in the future. But it may be more efficient to get all the major version upgrades out of the way now and then coast.
aednichols
left a comment
There was a problem hiding this comment.
Looking good pending one issue, log files.
ui/test-results.log
Outdated
| @@ -0,0 +1,542 @@ | |||
| - Generating browser application bundles (phase: setup)... | |||
There was a problem hiding this comment.
This and the other *.log file(s) do not seem like they should be checked in.
There was a problem hiding this comment.
oh yup I'll remove that
| Run the following command to upgrade to Angular 19 (change versions as needed): | ||
| `ng update @angular/core@15 @angular/cli@15` | ||
|
|
||
| This guide will also show a more in-depth list of changes to make when upgrading Angular versions: https://angular.dev/update-guide?v=14.0-19.0&l=2 |
| "options": { | ||
| "main": "src/test.ts", | ||
| "polyfills": "src/polyfills.ts", | ||
| "polyfills": ["src/polyfills.ts"], |
There was a problem hiding this comment.
I don't understand what they were thinking before, having "polyfills" plural be a single value?
I'll try updating to 20 and if it's not much additional effort, we might as well |
|
Ok so Clarity (pretty widely used package) doesn't support angular 20 yet, so I'm gonna stick with 19 for now: https://clarity.design/pages/support-policies |
|
Seems reasonable to me! I will be happy to approve once the log files go. |
LizBaldo
left a comment
There was a problem hiding this comment.
Thank you for working through this gnarly update!
https://broadworkbench.atlassian.net/browse/CTM-320
Security update, ran
ng updatefor each major version and had to do some cleanup for deprecations, then had to update the styling (with claude help)