Draft
Conversation
Game re-places the last piece after it is placed and a new one is generated. This only happens sometimes, I think because it depends on how the location was reached and isn't visible if lines weren't removed.
xMasterX
requested changes
Mar 14, 2023
Member
xMasterX
left a comment
There was a problem hiding this comment.
Hi, actually when you removed tetris_game_remove_curr_piece on line 299
it made game not work at all, it just starts on gameover screen and you can't restart it, it will go straight into game over screen
Adding tetris_game_remove_curr_piece back makes game work but pieces will not stay on bottom, they are removed instantly, so this is not a solution
Please fix described issues and test your changes, for now ill convert this PR to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Game re-places the last piece after it is placed and a new one is generated. This only happens sometimes, I think because it depends on how the location was reached and isn't visible if lines weren't removed.
What's new
The changes are:
wasDownMoveandtetris_game_piece_at_bottomelseto prevent rendering old pieceChecklist (For Reviewer)