Streamline file generation merged with latest main#1
Open
gonzodepedro wants to merge 15 commits intoDanMesh:streamline-file-generationfrom
Open
Streamline file generation merged with latest main#1gonzodepedro wants to merge 15 commits intoDanMesh:streamline-file-generationfrom
gonzodepedro wants to merge 15 commits intoDanMesh:streamline-file-generationfrom
Conversation
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
* Update the generator code to properly set float constants. * Small cleanups to rosidl_generator_tests. Get rid of some unnecessary macros, refactor the header includes, and make things static where possible. * Add in a new tests for assigning constants. In particular, we want to test float constants. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
There really isn't any need to use ament_target_dependencies. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
…s2#780) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35 to 41. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v35...v41) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This will fix warnings when using newer versions of flake8. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
The comment in the commit explains the reasoning behind it. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
…on how to update the code (ros2#788) Signed-off-by: Alexis Paques <paa1ti@bosch.com>
Signed-off-by: Gonzalo de Pedro <gonzalodepedro@ekumenlabs.com>
Owner
|
@gonzodepedro thanks for taking the time to do this update! I somehow missed that you opened this PR. Are you actively working on my PR ros2#769? Is this something you'd like to have merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps streamline file generation to the newest changes on main.