-
Notifications
You must be signed in to change notification settings - Fork 0
Fix inconsistent behavior between soft back key and back icon button #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures the device back button and the action bar back icon perform the same navigation in the search screens.
- Adds
BackHandlertoSearchRoutefor consistent back behavior. - Adds
BackHandlertoSearchResultRoutefor consistent back behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SearchScreen.kt | Imported BackHandler and wired onBackClick() to it |
| SearchResultScreen.kt | Imported BackHandler and wired onBackClick() to it |
Comments suppressed due to low confidence (2)
presentation/src/main/java/daily/dayo/presentation/screen/search/SearchScreen.kt:72
- Consider adding a UI or integration test to verify that both the hardware back button and the action bar back icon invoke
onBackClick()in this screen.
BackHandler {
presentation/src/main/java/daily/dayo/presentation/screen/search/SearchResultScreen.kt:109
- Consider adding a UI or integration test to verify that both the hardware back button and the action bar back icon invoke
onBackClick()in this screen.
BackHandler {
yuni-ju
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May-28-2025.22-22-05.mp4
-
최근검색어에서 키워드를 클릭했을때는 검색화면에서 바로 뒤로가기가 되는데, 직접 검색어를 입력한 후 뒤로가기를 누르면 두번 눌러야 뒤로가지는 현상이 발생합니다.
-
이건 이번 이슈랑은 관계 없지만... 최근 검색어에 test말고 아래 한글로된 검색어가 가운데 정렬이 안되어있는 것 --> 제가 습관적으로 엔터 버튼을 눌렀더니 검색어에 줄바꿈 기호가 포함되는 것 같더라구요! 요것도 추후 제거 되면 좋을 것 같아요
|
작업목표
작업사항
참고