Add Search history empty view #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an empty view to indicate when there is no search history.
- Added new string resources for the empty state in strings.xml.
- Modified SearchScreen.kt to conditionally display an empty view when search history data is empty.
- Introduced a new composable, SearchHistoryEmpty, to render the empty state UI.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| presentation/src/main/res/values/strings.xml | Added empty state strings for search history view |
| presentation/src/main/java/daily/dayo/presentation/screen/search/SearchScreen.kt | Updated search history layout to show empty state when appropriate |
Comment on lines
+322
to
+323
| .fillParentMaxHeight() | ||
| .fillMaxWidth(), |
There was a problem hiding this comment.
[nitpick] Consider using Modifier.fillMaxSize() instead of fillParentMaxHeight() for consistency and clarity, if that aligns with other layouts in the project.
Suggested change
| .fillParentMaxHeight() | |
| .fillMaxWidth(), | |
| .fillMaxSize(), |
yuni-ju
requested changes
May 28, 2025
Member
yuni-ju
left a comment
yuni-ju
left a comment
There was a problem hiding this comment.
Figma 디자인
실행 화면
아이콘과 텍스트 사이에 공백 추가 부탁드립니다
yuni-ju
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업사항
참고