-
Notifications
You must be signed in to change notification settings - Fork 96
Add CRAN announcment to Status #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
moving all nldi tests to "long running", so should only run when triggered... See merge request water/dataRetrieval!443
| message(txt) | ||
| return(txt) | ||
| message(returnedList) | ||
| returnedDoc <- returnedList |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ehinman this should help with:
stations <- c("06011000")
peakdata <- readNWISpeak(stations,
startDate = "2024-08-01",
endDate = "2024-08-31",
convertType = FALSE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Returns No sites/data found using the selection criteria specified
README.md
Outdated
| The USGS is planning to modernize all web services in the near future. | ||
| For each of these updates, `dataRetrieval` will create a new function to | ||
| access the new services. To access these services on a web browser, go | ||
| to <https://waterdata.usgs.gov/download-samples/>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So to verify, this is written as such because the new function is only on develop, and this is CRAN, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, meant to make it generalized to all the new services going forward. I'll just take out that last sentence "To access..."
| access the new services. To access these services on a web browser, go | ||
| to <https://waterdata.usgs.gov/download-samples/>. | ||
|
|
||
| ## New Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might make sense to put all of this in some kind of callout box so that it stands out as "this is future stuff" versus the httr2 info below that is relevant to the current CRAN version.
| |use|[readNWISuse](https://doi-usgs.github.io/dataRetrieval/reference/readNWISuse.html)|Water Use| | ||
| |meas|[readNWISmeas](https://doi-usgs.github.io/dataRetrieval/reference/readNWISmeas.html)|Discrete surface water| | ||
| | | [readNWISdata](https://doi-usgs.github.io/dataRetrieval/reference/readNWISdata.html) | General data import for NWIS| | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
ehinman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @ldecicco-USGS! Thanks. Approved.
|
GH action errors due to WQP beta services. |
|
Tacking into the pivot vignette the wide-to-long examples from a really old WDFN blog that is going to be archived. |
No description provided.