Skip to content

Conversation

@ldecicco-USGS
Copy link
Collaborator

No description provided.

moving all nldi tests to "long running", so should only run when triggered...

See merge request water/dataRetrieval!443
message(txt)
return(txt)
message(returnedList)
returnedDoc <- returnedList
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehinman this should help with:

stations <- c("06011000")
peakdata <- readNWISpeak(stations,
startDate = "2024-08-01",
endDate = "2024-08-31",
convertType = FALSE)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Returns No sites/data found using the selection criteria specified

README.md Outdated
The USGS is planning to modernize all web services in the near future.
For each of these updates, `dataRetrieval` will create a new function to
access the new services. To access these services on a web browser, go
to <https://waterdata.usgs.gov/download-samples/>.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to verify, this is written as such because the new function is only on develop, and this is CRAN, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, meant to make it generalized to all the new services going forward. I'll just take out that last sentence "To access..."

access the new services. To access these services on a web browser, go
to <https://waterdata.usgs.gov/download-samples/>.

## New Features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to put all of this in some kind of callout box so that it stands out as "this is future stuff" versus the httr2 info below that is relevant to the current CRAN version.

|use|[readNWISuse](https://doi-usgs.github.io/dataRetrieval/reference/readNWISuse.html)|Water Use|
|meas|[readNWISmeas](https://doi-usgs.github.io/dataRetrieval/reference/readNWISmeas.html)|Discrete surface water|
| | [readNWISdata](https://doi-usgs.github.io/dataRetrieval/reference/readNWISdata.html) | General data import for NWIS|

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Copy link
Collaborator

@ehinman ehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @ldecicco-USGS! Thanks. Approved.

@ldecicco-USGS
Copy link
Collaborator Author

GH action errors due to WQP beta services.

@ldecicco-USGS
Copy link
Collaborator Author

Tacking into the pivot vignette the wide-to-long examples from a really old WDFN blog that is going to be archived.

@ldecicco-USGS ldecicco-USGS merged commit 859b578 into DOI-USGS:main Mar 26, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants