missing include: ARGV.h

[okan-nako]

This missing include causes compile errors while building ARGV.cpp on some platforms.

Summary by CodeRabbit

• Chores
  • Internal code maintenance adjustment.

---

Note: This release contains no user-facing changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Added an include directive for the ARGV header file in the ARGV.cpp translation unit. This establishes an explicit dependency on the public interface header within the corresponding implementation file. No functional logic changes introduced.

Changes

Cohort / File(s)	Change Summary
Include Directive Addition ACE/ace/ARGV.cpp	Added #include "ace/ARGV.h" to include the ARGV header in the implementation file

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny include, so small and neat,
Headers and implementations now meet!
One line of magic, arranged just right,
Dependencies aligned, dependencies bright! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'missing include: ARGV.h' accurately describes the main change in the pull request, which adds a missing include directive for ARGV.h to ARGV.cpp.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

---

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63243fd and 30d5ded.

📒 Files selected for processing (1)

• ACE/ace/ARGV.cpp

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: ubuntu-24.04 g++-10 wchar
• GitHub Check: ubuntu-24.04 g++-13
• GitHub Check: ubuntu-24.04 clang++-20 c++23
• GitHub Check: ubuntu-24.04 g++-10 CORBA/e compact
• GitHub Check: ubuntu-24.04 g++-10 ACE for TAO
• GitHub Check: ubuntu-22.04 clang++-13
• GitHub Check: ubuntu-22.04 g++-9
• GitHub Check: ubuntu-24.04 g++-10 CodeQL
• GitHub Check: ubuntu-24.04 g++-10 CORBA/e micro
• GitHub Check: ubuntu-24.04 g++-12
• GitHub Check: ubuntu-22.04 clang++-12
• GitHub Check: ubuntu-24.04 g++-14
• GitHub Check: ubuntu-24.04 g++-11
• GitHub Check: ubuntu-24.04 clang++-15
• GitHub Check: ubuntu-24.04 clang++-16
• GitHub Check: ubuntu-24.04 clang++-20
• GitHub Check: ubuntu-24.04 clang++-14
• GitHub Check: ubuntu-22.04 g++-10
• GitHub Check: VS2022Release64
• GitHub Check: ubuntu-24.04 g++

🔇 Additional comments (1)

ACE/ace/ARGV.cpp (1)

4-4: Good add: explicit dependency in implementation.

This should resolve the missing-include build issue without side effects.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jwillemsen]

This is a template file, ARGV.h already includes ARGV.cpp, so this is not a correct fix

[okan-nako]

OK. Anyway, we get errors like below if ARGV.h is not included from ARGV.cpp. Building of Process.cpp and Service_Gestalt.cpp are all right, since they both include ARGV.h but ARGV.cpp not

---------- ERRORS occurred while compiling file ARGV.cpp
...
ace/ARGV.cpp:79:1: error: 'ACE_ARGV_T' does not name a type; did you mean 'ACE_ARGV_CPP'?
ACE_ARGV_T<CHAR_TYPE>::ACE_ARGV_T (const CHAR_TYPE buf[],

[jwillemsen]

Could it be that CHAR_TYPE is a define on your platform?

[okan-nako]

Could it be that CHAR_TYPE is a define on your platform?

According to my search -> No. Only "WCHAR_TYPE" is defined : #define WCHAR_TYPE int.

if i get more info about CHAR_TYPE define, i will inform here.