Use nullptr/default/override

[jwillemsen]

* ACE/examples/Reactor/WFMO_Reactor/Registration.cpp:
* ACE/tests/Bug_2820_Regression_Test.cpp:

Summary by CodeRabbit

• Refactor

  • Enhanced code quality through modernization of C++ practices and improved initialization patterns for better maintainability.
  • Updated method signatures with modern language features for clarity and consistency.

• Documentation

  • Fixed minor documentation comment.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This pull request modernizes C++ code in a reactor example by replacing int-based flags with bool, converting raw pointers from NULL to nullptr, adding override specifiers, using defaulted constructors, and applying brace-initialization for member variables. A typo in a test comment is also corrected.

Changes

Cohort / File(s)	Summary
Modern C++ Refactoring ACE/examples/Reactor/WFMO_Reactor/Registration.cpp	Type conversion: int stop_test → bool; default constructor defaulted; nullptr replacements; override specifiers added to handle_signal and handle_close; member variables initialized with braces; function formatting adjusted for consistency.
Documentation Fix ACE/tests/Bug_2820_Regression_Test.cpp	Comment typo corrected: "refence_count" → "the reference_count".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• Use nullptr/default/override in multiple ACE classes #2348: Applies identical modernization patterns (nullptr, override, defaulted constructors) to WFMO_Reactor components including handle_signal signature updates.

Poem

🐰 A time for modernizing code,
With nullptr and override bestowed,
Bool flags replace the int of old,
Constructors defaulted, clean and bold,
ACE examples now refactored, true!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Use nullptr/default/override' directly and clearly summarizes the main change: modernizing C++ code to use these three modern C++ keywords across the affected files.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b55e85 and eaf89a8.

📒 Files selected for processing (2)

• ACE/examples/Reactor/WFMO_Reactor/Registration.cpp
• ACE/tests/Bug_2820_Regression_Test.cpp

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: windows-2022 vs2022
• GitHub Check: ubuntu-24.04 clang++-20
• GitHub Check: ubuntu-24.04 clang++-15
• GitHub Check: ubuntu-24.04 clang++-16
• GitHub Check: ubuntu-24.04 g++-10 CORBA/e compact
• GitHub Check: ubuntu-24.04 g++-10 ACE for TAO
• GitHub Check: ubuntu-24.04 g++
• GitHub Check: macos-14-C++
• GitHub Check: ubuntu-24.04 g++-10 CORBA/e micro
• GitHub Check: ubuntu-24.04 clang++-20 c++23
• GitHub Check: ubuntu-24.04 clang++-14
• GitHub Check: ubuntu-24.04 g++-10 wchar
• GitHub Check: ubuntu-22.04 clang++-13
• GitHub Check: ubuntu-24.04 g++-10 CodeQL
• GitHub Check: ubuntu-24.04 g++-12
• GitHub Check: ubuntu-22.04 g++-9
• GitHub Check: ubuntu-24.04 g++-14
• GitHub Check: ubuntu-24.04 g++-11
• GitHub Check: ubuntu-22.04 g++-10
• GitHub Check: ubuntu-24.04 g++-13

🔇 Additional comments (6)

ACE/tests/Bug_2820_Regression_Test.cpp (1)

80-80: LGTM!

Typo correction in comment is accurate and improves readability.

ACE/examples/Reactor/WFMO_Reactor/Registration.cpp (5)

37-37: LGTM!

Using bool for a flag variable is semantically clearer and aligns with modern C++ practices.

---

43-52: LGTM!

Good modernization of the class declaration:

• Defaulted constructor with in-class member initialization is cleaner
• override specifiers ensure compile-time checking of virtual function overrides
• nullptr is the correct modern replacement for NULL/0
• Brace initialization {} for integers value-initializes to zero

---

54-75: LGTM!

Good refinements to the implementation:

• const on the local variable is a good defensive practice
• Pre-increment is idiomatic C++
• Logic remains intact

---

77-89: LGTM!

The bool values false/true are semantically clearer than the previous integer values. The logic correctly stops the test loop only after both handlers have been closed.

---

123-127: LGTM!

Single-line formatting for the registration calls improves consistency.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}