Removed stl feature flag, we require STL support, add missing break

[jwillemsen]

* ACE/bin/MakeProjectCreator/config/stl.mpb: Deleted.

* ACE/bin/MakeProjectCreator/config/global.features:
* TAO/docs/tutorials/Quoter/RTCORBA/Distributor.cpp:
* TAO/docs/tutorials/Quoter/RTCORBA/StockQuoter.mpc:

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Fixed command-line argument parsing to prevent unintended behavior when using specific options.

• Chores

  • Removed STL-related feature declarations and project capabilities from configuration files.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

These changes remove STL feature support from ACE/TAO build configuration and MPC project files across multiple locations. Additionally, a missing break statement is added to prevent unintended case fall-through in command-line argument parsing within a sample application.

Changes

Cohort / File(s)	Summary
STL feature removal ACE/bin/MakeProjectCreator/config/global.features, ACE/bin/MakeProjectCreator/config/stl.mpb, TAO/docs/tutorials/Quoter/RTCORBA/StockQuoter.mpc	Removed stl feature declarations and dependencies from global build configuration, MPC feature module, and three project signatures (RTCORBA_Quoter_Admin, RTCORBA_Quoter_Distributor, RTCORBA_Quoter_Broker).
Control flow fix TAO/docs/tutorials/Quoter/RTCORBA/Distributor.cpp	Added missing break statement to case 'u' in parse_args function to prevent fall-through to case 'c' and unintended flag enabling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• The changes are straightforward feature removals across configuration files and a trivial control flow fix (single break statement addition).
• Areas for attention: Verify that removing the stl dependency from the three Quoter projects does not introduce link-time errors; confirm that the break statement addition in Distributor.cpp aligns with intended -u option behavior.

Poem

🐰 wiggles nose at clean config
STL feature hops away today,
Parse_args now breaks the fall-through way,
Code flows straight without delay,
A rabbit's build—perfected, hooray! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: removing STL feature flags (from global.features and .mpc files) and adding a missing break statement in Distributor.cpp.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3abc747 and 1965a42.

📒 Files selected for processing (4)

• ACE/bin/MakeProjectCreator/config/global.features (0 hunks)
• ACE/bin/MakeProjectCreator/config/stl.mpb (0 hunks)
• TAO/docs/tutorials/Quoter/RTCORBA/Distributor.cpp (1 hunks)
• TAO/docs/tutorials/Quoter/RTCORBA/StockQuoter.mpc (3 hunks)

💤 Files with no reviewable changes (2)

• ACE/bin/MakeProjectCreator/config/stl.mpb
• ACE/bin/MakeProjectCreator/config/global.features

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: VS2022Debug64Cxx17
• GitHub Check: ubuntu-24.04 g++-10 CORBA/e micro
• GitHub Check: MINGW64-gcc
• GitHub Check: ubuntu-24.04 g++-10 CORBA/e compact
• GitHub Check: ubuntu-24.04 g++-10 CodeQL
• GitHub Check: ubuntu-24.04 clang++-14
• GitHub Check: ubuntu-24.04 clang++-16
• GitHub Check: ubuntu-24.04 g++-10 wchar
• GitHub Check: ubuntu-24.04 g++-11
• GitHub Check: ubuntu-24.04 g++-12
• GitHub Check: ubuntu-22.04 clang++-13
• GitHub Check: ubuntu-22.04 clang++-12
• GitHub Check: ubuntu-22.04 g++-10
• GitHub Check: ubuntu-24.04 g++-13
• GitHub Check: ubuntu-24.04 g++-14
• GitHub Check: ubuntu-22.04 g++-9
• GitHub Check: windows-2022 vs2022
• GitHub Check: alpine-3.18
• GitHub Check: ubuntu-24.04 g++
• GitHub Check: macos-14-C++
• GitHub Check: macos-13-C++

🔇 Additional comments (2)

TAO/docs/tutorials/Quoter/RTCORBA/Distributor.cpp (1)

43-48: Fixing unintended -u → -c fall‑through in option parsing

Adding the break; after handling -u correctly prevents -u from also enabling use_naming, aligning runtime behavior with the documented usage where -u and -c are independent flags. Change looks correct and localized.

TAO/docs/tutorials/Quoter/RTCORBA/StockQuoter.mpc (1)

35-35: Aligning Quoter MPC projects with removal of stl feature

Dropping stl from the RTCORBA_Quoter_* project signatures is consistent with removing the separate stl feature/mpb and requiring STL support unconditionally. The updated bases (valuetype, rt_server, naming[, utils, threads]) are appropriate for these tutorial projects and should keep them buildable without relying on a now-absent feature.

Also applies to: 51-51, 73-73

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}