Skip to content

AXFRDDNS: support unix domain sockets in update-mode/transfer-mode #4304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomfitzhenry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

AXFRDDNS: support unix domain sockets in update-mode/transfer-mode #4304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions documentation/provider/axfrddns.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ To use this provider, add an entry to `creds.json` with `TYPE` set to `AXFRDDNS`

Zone transfers and DDNS updates default to TCP when using this provider.

The following two parameters in `creds.json` allow switching to TCP or TCP over TLS.
The following two parameters in `creds.json` allow switching to TCP, TCP over TLS, or Unix domain sockets.

* `update-mode`: May contain `tcp` (the default), `udp`, or `tcp-tls`.
* `transfer-mode`: May contain `tcp` (the default), or `tcp-tls`.
* `update-mode`: May contain `tcp` (the default), `udp`, `tcp-tls`, or `unix`.
* `transfer-mode`: May contain `tcp` (the default), `tcp-tls`, or `unix`.

When using `unix` mode, `master` and/or `transfer-server` should be set to the path of the Unix domain socket.

### Authentication

Expand Down
15 changes: 9 additions & 6 deletions providers/axfrddns/axfrddnsProvider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func initAxfrDdns(config map[string]string, providermeta json.RawMessage) (provi
}
if config["update-mode"] != "" {
switch config["update-mode"] {
case "tcp", "tcp-tls":
case "tcp", "tcp-tls", "unix":
api.updateMode = config["update-mode"]
case "udp":
api.updateMode = ""
Expand All @@ -125,7 +125,7 @@ func initAxfrDdns(config map[string]string, providermeta json.RawMessage) (provi
}
if config["transfer-mode"] != "" {
switch config["transfer-mode"] {
case "tcp", "tcp-tls":
case "tcp", "tcp-tls", "unix":
api.transferMode = config["transfer-mode"]
default:
printer.Printf("[Warning] AXFRDDNS: Unknown transfer-mode in `creds.json` (%s)\n", config["transfer-mode"])
Expand All @@ -135,7 +135,7 @@ func initAxfrDdns(config map[string]string, providermeta json.RawMessage) (provi
}
if config["master"] != "" {
api.master = config["master"]
if !strings.Contains(api.master, ":") {
if api.updateMode != "unix" && !strings.Contains(api.master, ":") {
api.master = api.master + ":53"
}
} else if len(api.nameservers) != 0 {
Expand All @@ -145,7 +145,7 @@ func initAxfrDdns(config map[string]string, providermeta json.RawMessage) (provi
}
if config["transfer-server"] != "" {
api.transferServer = config["transfer-server"]
if !strings.Contains(api.transferServer, ":") {
if api.transferMode != "unix" && !strings.Contains(api.transferServer, ":") {
api.transferServer = api.transferServer + ":53"
}
} else {
Expand Down Expand Up @@ -247,10 +247,13 @@ func (c *axfrddnsProvider) GetNameservers(domain string) ([]*models.Nameserver,
func (c *axfrddnsProvider) getAxfrConnection() (*dnsv1.Transfer, error) {
var con net.Conn
var err error
if c.transferMode == "tcp-tls" {
switch c.transferMode {
case "tcp-tls":
// RFC 9103 "DNS Zone Transfer over TLS" section 7.1 requires "dot"
con, err = tls.Dial("tcp", c.transferServer, &tls.Config{NextProtos: []string{"dot"}})
} else {
case "unix":
con, err = net.Dial("unix", c.transferServer)
default:
con, err = net.Dial("tcp", c.transferServer)
}
if err != nil {
Expand Down
Loading