RWTH: Add Support for Domains with DNSSEC Disabled and Migrate to diff2#4180
Merged
Conversation
MisterErwin
approved these changes
Mar 30, 2026
MisterErwin
left a comment
MisterErwin
left a comment
Contributor
There was a problem hiding this comment.
looks good to me (and was tested against the live system)
Collaborator
|
FYI: Things are stalled right now. I hope I can get back to DNSControl next week. |
Collaborator
|
Please rebase |
Collaborator
|
Greetings! Thank you for your patience while we migrated to the new GitHub org. Now that the migration is complete, please rebase. Thank you. |
psuet
force-pushed
the
rwth-dnssec-disabled
branch
from
b6895d8 to
f7bcd9c
Compare
TomOnTime
approved these changes
Jun 18, 2026
TomOnTime
left a comment
TomOnTime
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! I'm sure users will appreciate the reliability gains from using Diff2!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the RWTH Provider only supports domains with DNSSEC enabled, since the return values of the zone-lookup call are different for the different DNSSEC states.
This PR fixes this problem.
Additionally the provider now uses the diff2 instead of the old diff1.
@MisterErwin :)