Skip to content

Move handler creation to onAttachedToWindow() instead of the constructor #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MimiReader wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move handler creation to onAttachedToWindow() instead of the constructor #824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions android-pdf-viewer/src/main/java/com/github/barteksc/pdfviewer/PDFView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,6 @@ ScrollHandle getScrollHandle() {
public PDFView(Context context, AttributeSet set) {
super(context, set);

renderingHandlerThread = new HandlerThread("PDF renderer");

if (isInEditMode()) {
return;
}
Expand Down Expand Up @@ -462,6 +460,12 @@ public void computeScroll() {
animationManager.computeFling();
}

@Override
protected void onAttachedToWindow() {
super.onAttachedToWindow();
renderingHandlerThread = new HandlerThread("PDF renderer");
}

@Override
protected void onDetachedFromWindow() {
recycle();
Expand Down