Sapphire v2.6.006 - Fixed 2 bugs: expanders + user defaults. - #936
Merged
Conversation
This is a maintenance release for Sapphire that includes two bug fixes: 1. Automatic creation of the chain still happens in Echo and Empath after setting user defaults. 2. Apply user defaults to expander buttons like "Insert Tricorder", "Insert Chaops", etc.
Contributor
Author
|
This PR looks ready to merge to me. I'm glad the remote service outages apparently have been fixed. |
Collaborator
|
you're right. thnx again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a maintenance release for Sapphire that includes two bug fixes needed in VCV Rack:
My understanding is that Cardinal does not support configurable user defaults using a
template.vcvmfile like VCV Rack does. If this is correct, then neither of these changes is likely to be significant for Cardinal. I believe they will not do anything actually. I did some testing building Cardinal + Sapphire from source locally on my Linux Intel 64 system, and affected Sapphire modules are working correctly.I just want to make sure the code is always in sync between the two projects, even when the change shouldn't affect user experience in Cardinal.
Thank you!