Update for JW-Modules - #924
Merged
Merged
Conversation
Contributor
Author
|
Ug. I did not test the LTO build. I think I see what's up. I suspect this may be due to other code that changed between the last update of JW-Modules and my work. But, you touch it, you own it. :-) I'll go figure this out. Given that I'll need make a modification to the JW-Modules code and get the PR completed on that repo, it might be a day or two. I apologize for the noob question, but is the proper process to cancel this PR and open an new one when I fix the issue OR can this PR be amended once I've addressed the issue at hand? |
Collaborator
|
You can just push updates to this PR until it passes CI + review :) |
Contributor
Author
|
I'm running the LTO build right now. I think the change may be five lines. |
Collaborator
|
@falkTX looks good to me. can we merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to include changes to JW-Modules. Rebuilt Cardinal from source with updates. Tested of updated JW-Modules both in VCV Rack and Cardinal. See pull request on JW-Modules repo for testing details.