01a02039 - Drop leftover call-queue clerks list - #1416
Merged
Conversation
The outcome form already uses the logged-in staff verified name. Remove the unused clerks-list helper and the e2e seed that only existed to feed that list.
Contributor
Author
|
EN: DE: DetailsOne review pass, 0 findings on quality and logic. Comments: no issue comments, reviews, inline comments, or review threads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
The call-queue outcome form no longer has a leftover client for the clerks list. Signature stays the logged-in staff verified name, and a regression test asserts there is no clerk select. The e2e seed that only existed to populate that list is gone.
DE:
Das Call-Queue-Outcome-Formular hat keinen übrig gebliebenen Client mehr für die Clerks-Liste. Die Signatur bleibt der verified name des eingeloggten Staff, und ein Regressionstest stellt sicher, dass es kein Clerk-Select gibt. Der E2E-Seed, der nur diese Liste füllte, entfällt.
Details
Production still shows a clerk dropdown because it ships an older frontend that calls
GET support/call-queues/clerks. Current develop already renders a read-only verified name (PR 1410). This change removes the unusedgetCallQueueClerkshelper and the e2ecomplianceClerkssetting seed.The acting clerk on write is stamped by the API from the auth token. Ticket-assignment clerk dropdowns on support issues are unchanged: those assign work to a colleague, they are not self-identification.