Fix subscribestar.adult attachment grabbing, HC inlines#201
Open
roachcord3 wants to merge 2 commits intoCuddleBear92:masterfrom
Open
Fix subscribestar.adult attachment grabbing, HC inlines#201roachcord3 wants to merge 2 commits intoCuddleBear92:masterfrom
roachcord3 wants to merge 2 commits intoCuddleBear92:masterfrom
Conversation
Not an April Fools, despite the unfortunate date in the filename. I noticed that I had a bug in my parser: it was not downloading attachments correctly and was giving them the wrong filename, mixing them up with image gallery items. Not sure why. The fix was to move the parsing logic to a sub-parser. Also added a URL class for CDN links to help with Hydrus Companion inline highlighting in some cases. It's not perfect, so you can delete it after importing if you want.
It literally is tested on attachments too, so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not an April Fools, despite the unfortunate date in the filename.
I noticed that I had a bug in my parser: it was not downloading attachments correctly and was giving them the wrong filename, mixing them up with image gallery items. Not sure why.
The fix was to move the parsing logic to a sub-parser.
Also added a URL class for CDN links to help with Hydrus Companion inline highlighting in some cases. It's not perfect, so you can delete it after importing if you want.