Rc/fix sprites#161
Open
jnterry wants to merge 5 commits into
Open
Conversation
…uld probably be reverted after demo day, but will do for now
grant-m-s
requested review from
AnthonyWharton,
Codrin-Popa,
RcColes,
grant-m-s and
qqii
Member
|
It may be fixed, but this would also be nice to have. |
qqii
reviewed
Apr 18, 2018
qqii
left a comment
qqii
left a comment
Member
There was a problem hiding this comment.
I'm actually a little worried about performance issues as the entire spritesheet won't be loaded at once. I think this is one to archive and look at if issues come back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since no-one has been able to fix sprite sheets I cheated for the demo tomorrow - this uses loose textures and just switches between them.
Ideally this would be reverted after demo day, but it works so provided the performance hit isn't too great maybe this will be the final solution.