feat: optimisation of subdivision process#1509
Merged
DavePearce merged 3 commits intomainfrom Feb 18, 2026
Merged
Conversation
There was some unnecessary logging going on.
This reverts the chunking algorithm back to the original which, although less optimal, is much more efficient. However, the new chunking algorithm is retained and can be enabled with a flag (in principle).
Previously, this was printing the debug information as requested, but then it was also causing a panic. Fixed now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core arithmetic constraint splitting logic; incorrect overflow detection or subdivision could change generated constraints or cause panics, though the new behavior is guarded by explicit overflow checks and a loop-stuck fail-fast.
Overview
Assignment splitting is reworked to reduce unnecessary subdivision.
Assignment.chunkUpnow iteratively applies aRegisterSplitter, detects which RHS sub-polynomials exceedfield.BandWidthvia a newdetermineRhsChunksthat returns an overflow register set, and only subdivides those registers (with a stuck-loop guard that panics with debug output).Experimental path remains but is gated. A
USE_NEW_CHUNKUPflag selects the olderchunkUp2path (still present, withdetermineRhsChunks2retained undernolint), but defaults tofalseso the new iterative splitter is the default.Minor cleanup/robustness. Removes perf-stat logging from lowering/vectorization, and makes
debug.PrintSchemasskip printing the concrete schema when absent (HasConcreteSchema()).Written by Cursor Bugbot for commit 9e7f8f5. This will update automatically on new commits. Configure here.