fix(webgpu): release GPU resources on failure - #1795
Draft
CharlesHoskinson wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
mapAsyncfailsGPUDeviceand prevent reuse of a closed buffer poolWhy
Browser proving allocates large GPU buffers. Previously, cleanup happened only after a successful readback, so WebGPU validation, shader, or device-loss errors could retain those allocations and make fallback or retry unsafe.
Validation
npm run lintnpm test(5 tests)GOOS=js GOARCH=wasm go build -buildvcs=false ./backend/accelerated/webgpu/...go test -short ./...was also attempted; the WebGPU/backend packages passed, while the full run hit two checkout-environment issues: WSL could not resolve the Windows worktree gitdir forTestVersion, and Solidity golden files differed only by CRLF/LF line endings.Light Reading
Have a look at my repo for more context. I have a full implementation running in WASM https://github.com/CharlesHoskinson/proof-zk-recovery