Added logic to add cuda compute cap. 10.0 when toolchain is 12.9.1 or greater by ccoulombe · Pull Request #82 · ComputeCanada/easybuild-computecanada-config

ccoulombe · 2026-01-09T20:56:09Z

When cuda 12.9.1 is used, add cuda compute capabiliy 10.0 to --cuda-compute-capabilities build option.

2023/cc_hooks.py

mboisson · 2026-03-26T19:15:36Z

2023/cc_hooks.py


+    ccc = build_option('cuda_compute_capabilities')
+    # For CUDA and CUDAcore, 12.9 or higher, add cuda compute 10.0
+    if (ec['toolchain'].get('name', '').startswith('CUDA') and ec['toolchain'].get('version', '').startswith(('12.9', '13.'))) or \


faudrait pas aussi inclure les toolchains cuda+mpi ?

Ils sont automatiquement inclus, puisqu'ils ont une dépendence sur cuda, non ?

Pour la forme, je peux les ajouters explicitement

ben, dans ma tête en tout cas, ec['toolchain'].get('name', '') ne débute pas avec CUDAsi la toolchain est gompic ou gcccuda

CUDA ou CUDAcore fera alors partie des builddeps je crois, donc la 2e condition sera vraie.
Je vais le vérifier.

ie

elif ec['toolchain']['name'] == 'gcccorecuda': builddeps.append(('CUDAcore', '%(cudaver)s'))

ccoulombe · 2026-03-26T19:16:12Z

Tested

eb cuDSS-0.7.1-CUDAcore-12.9.1.eb --try-toolchain=CUDAcore,12.9.1 --hooks=$HOME/easybuild-computecanada-config/2023/cc_hooks.py --rebuild

eb cuDSS-0.7.1-CUDAcore-12.9.1.eb --try-toolchain=CUDAcore,12.6.3 --hooks=$HOME/easybuild-computecanada-config/2023/cc_hooks.py --rebuild

eb cuDSS-0.6.0-CUDAcore-12.6.2.eb --hooks=$HOME/easybuild-computecanada-config/2023/cc_hooks.py --rebuild

eb cuDSS-0.6.0-CUDAcore-12.6.2.eb --hooks=$HOME/easybuild-computecanada-config/2023/cc_hooks.py --rebuild --try-toolchain=CUDAcore,12.9.1

2023/cc_hooks.py

mboisson · 2026-03-26T19:17:57Z

à la place d'y aller avec les versions de cuda et de toolchain, on ne pourrait pas faire un appel à nvcc avec la toolchain loadée pour trouver quelles sont les versions supportées et filtrer/ajouter en conséquence ?

Copilot

Pull request overview

Adds hook logic in the 2023 EasyBuild configuration to automatically extend --cuda-compute-capabilities with compute capability 10.0 when building with CUDA toolchains/dependencies matching CUDA 12.9.x / 13.x.

Changes:

Import update_build_option from easybuild.tools.config.
In parse_hook, detect CUDA 12.9/13 toolchains or CUDA builddeps and append 10.0 to cuda_compute_capabilities.
Attempt to remove 10.0 from cuda_compute_capabilities when the current easyconfig is not using CUDA 12.9/13.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

2023/cc_hooks.py

Copilot · 2026-03-26T19:19:10Z

2023/cc_hooks.py

+    if (ec['toolchain'].get('name', '').startswith('CUDA') and ec['toolchain'].get('version', '').startswith(('12.9', '13.'))) or \
+        any(dep[0].startswith('CUDA') and dep[1].startswith(('12.9', '13.')) for dep in builddeps):


builddeps is sometimes populated in this hook with a literal placeholder version '%(cudaver)s' (see the builddeps.append(('CUDAcore', '%(cudaver)s')) branches above). In those cases, dep[1].startswith(('12.9', '13.')) will never match, so the 10.0 capability won’t be added even when the underlying CUDA version is 12.9.1+. Consider resolving the template value for cudaver (or inspecting the selected CUDA/CUDAcore module version from the toolchain) before making this decision.

Suggested change

if (ec['toolchain'].get('name', '').startswith('CUDA') and ec['toolchain'].get('version', '').startswith(('12.9', '13.'))) or \

any(dep[0].startswith('CUDA') and dep[1].startswith(('12.9', '13.')) for dep in builddeps):

cudaver_resolved = ec.get('cudaver') or EASYCONFIG_CONSTANTS.get('cudaver')

cuda_tc_name = ec['toolchain'].get('name', '')

cuda_tc_ver = ec['toolchain'].get('version', '')

if cuda_tc_ver == '%(cudaver)s' and cudaver_resolved:

cuda_tc_ver = str(cudaver_resolved)

def _cuda_dep_is_129_or_newer(dep):

name, ver = dep

if ver == '%(cudaver)s' and cudaver_resolved:

ver = str(cudaver_resolved)

return name.startswith('CUDA') and ver.startswith(('12.9', '13.'))

if (cuda_tc_name.startswith('CUDA') and cuda_tc_ver.startswith(('12.9', '13.'))) or \

any(_cuda_dep_is_129_or_newer(dep) for dep in (builddeps or [])):

2023/cc_hooks.py

ccoulombe · 2026-03-26T19:48:58Z

à la place d'y aller avec les versions de cuda et de toolchain, on ne pourrait pas faire un appel à nvcc avec la toolchain loadée pour trouver quelles sont les versions supportées et filtrer/ajouter en conséquence ?

ça impliquerais de charger le module à ce moment dans le hook, je ne sais pas si c'est possible à cette étape

bartoldeman · 2026-04-02T12:33:33Z

For 13.2 we'll have to remove cc 7.0 as well.

ccoulombe · 2026-04-02T13:31:33Z

For 13.2 we'll have to remove cc 7.0 as well.

We should remove it in general, here:

easybuild-computecanada-config/2023/config.cfg

Line 4 in 97398ce

cuda-compute-capabilities = 7.0,8.0,9.0

ccoulombe · 2026-04-02T13:49:46Z

xref: #86

Added logic to add cuda compute cap. 10.0 when toolchain is 12.9.1

2ef4863

ccoulombe requested review from bartoldeman and removed request for bartoldeman January 9, 2026 20:56

Must also remove it when not 12.9.1 (facepalm)...

a9c68b2

mboisson reviewed Jan 12, 2026

View reviewed changes

2023/cc_hooks.py Outdated Show resolved Hide resolved

Added CUDA 12.9, and future cuda 13.* toolchains

87d8fce

ccoulombe marked this pull request as ready for review March 26, 2026 19:12

ccoulombe requested review from bartoldeman, Copilot and mboisson March 26, 2026 19:12

Copilot started reviewing on behalf of ccoulombe March 26, 2026 19:13 View session

mboisson reviewed Mar 26, 2026

View reviewed changes

2023/cc_hooks.py Outdated Show resolved Hide resolved

Copilot AI reviewed Mar 26, 2026

View reviewed changes

ccoulombe changed the title ~~[WIP] Added logic to add cuda compute cap. 10.0 when toolchain is 12.9.1~~ Added logic to add cuda compute cap. 10.0 when toolchain is 12.9.1 or greater Mar 26, 2026

Compare using LooseVersion for anything higher than 12.9.1

c6b1801

		if (ec['toolchain'].get('name', '').startswith('CUDA') and ec['toolchain'].get('version', '').startswith(('12.9', '13.'))) or \
		any(dep[0].startswith('CUDA') and dep[1].startswith(('12.9', '13.')) for dep in builddeps):

-    if (ec['toolchain'].get('name', '').startswith('CUDA') and ec['toolchain'].get('version', '').startswith(('12.9', '13.'))) or \
-        any(dep[0].startswith('CUDA') and dep[1].startswith(('12.9', '13.')) for dep in builddeps):
+    cudaver_resolved = ec.get('cudaver') or EASYCONFIG_CONSTANTS.get('cudaver')
+    cuda_tc_name = ec['toolchain'].get('name', '')
+    cuda_tc_ver = ec['toolchain'].get('version', '')
+    if cuda_tc_ver == '%(cudaver)s' and cudaver_resolved:
+        cuda_tc_ver = str(cudaver_resolved)
+    def _cuda_dep_is_129_or_newer(dep):
+        name, ver = dep
+        if ver == '%(cudaver)s' and cudaver_resolved:
+            ver = str(cudaver_resolved)
+        return name.startswith('CUDA') and ver.startswith(('12.9', '13.'))
+    if (cuda_tc_name.startswith('CUDA') and cuda_tc_ver.startswith(('12.9', '13.'))) or \
+        any(_cuda_dep_is_129_or_newer(dep) for dep in (builddeps or [])):

Conversation

ccoulombe commented Jan 9, 2026

Uh oh!

Uh oh!

mboisson Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

ccoulombe Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mboisson Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

ccoulombe Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ccoulombe commented Mar 26, 2026

Uh oh!

Uh oh!

mboisson commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ccoulombe commented Mar 26, 2026

Uh oh!

bartoldeman commented Apr 2, 2026

Uh oh!

ccoulombe commented Apr 2, 2026

Uh oh!

ccoulombe commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ccoulombe Mar 26, 2026 •

edited

Loading

ccoulombe Mar 26, 2026 •

edited

Loading