Skip to content

Add loading and not-found pages for app and sessions#929

Merged
ashish921998 merged 10 commits intomainfrom
ashish921998/404-loading-pages
Apr 6, 2026
Merged

Add loading and not-found pages for app and sessions#929
ashish921998 merged 10 commits intomainfrom
ashish921998/404-loading-pages

Conversation

@ashish921998
Copy link
Copy Markdown
Collaborator

@ashish921998 ashish921998 commented Apr 5, 2026

Closes #799
This adds app-level and session-level loading.tsx and not-found.tsx routes so route transitions and 404s render dedicated UI instead of falling back to generic behavior.\n\nEach route includes focused tests for the new loading spinners and not-found states.\n\nIt also stabilizes isolated workspace checks by making web and cli typecheck build their workspace dependencies first and by adding Vitest aliases for local workspace package resolution.\n\nThat keeps package-local verification working without changing the shipped UI behavior beyond the new loading and 404 screens.

ashish921998 and others added 7 commits April 5, 2026 20:38
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…k mock

Polling errors no longer throw to the error boundary when a session is
already loaded, preventing transient network blips from unmounting the
view. Added missing next/link mock in error.test.tsx.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ashish921998 and others added 2 commits April 6, 2026 09:01
…link mock

Transient 404 during polling no longer kicks user off an active session
view. Also added missing next/link mock in session error test.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0e3f6c8. Configure here.

@harsh-batheja harsh-batheja self-requested a review April 6, 2026 07:10
@ashish921998 ashish921998 merged commit bfb3a32 into main Apr 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 404 pages and loading states: not-found.tsx and loading.tsx

2 participants