feat: add built-in acpx agent plugin#618
feat: add built-in acpx agent plugin#618sisutuulenisa wants to merge 4 commits intoComposioHQ:mainfrom
Conversation
|
|
||
| export interface AcpxAgentConfig extends AgentSpecificConfig { | ||
| acpxAgent?: AcpxAgentName; | ||
| } |
There was a problem hiding this comment.
Agent-specific field pollutes shared base type, creating redundancy
Low Severity
acpxAgent is added directly to the shared AgentSpecificConfig base type, which pollutes all agent configs with an ACPX-specific field. This also makes the new AcpxAgentConfig interface completely redundant — it extends AgentSpecificConfig and only re-declares acpxAgent, which is already present on the parent. The as AcpxAgentConfig | undefined cast in the plugin is therefore unnecessary. This is inconsistent with how OpenCodeAgentConfig handles opencodeSessionId, which correctly lives only on the subtype.
Additional Locations (1)
|
Applied Cursor review fix in Pushed follow-up commit: |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| export const DEFAULT_PROMPT_FLUSH_DELAY_MS = 150; | ||
| export const SUPPORTED_ACPX_AGENTS = [DEFAULT_ACPX_AGENT, "codex", "claude", "gemini"] as const; | ||
|
|
||
| export type SupportedAcpxAgent = (typeof SUPPORTED_ACPX_AGENTS)[number]; |
There was a problem hiding this comment.
Duplicate agent enum across bridge, config, and types
Low Severity
The set of supported ACPX agent names ("pi", "codex", "claude", "gemini") is independently defined in four places: SUPPORTED_ACPX_AGENTS in bridge.ts, AcpxAgentName in types.ts, and two z.enum(…) calls in config.ts. Adding a new agent requires updating all four in lockstep with no compiler or runtime guard against divergence.
Additional Locations (2)
Triggered by project rule: BugBot Configuration
|
Review completed by Genesis Coder. Looks solid, no serious bugs found. |
c1b9124 to
2f26c00
Compare
|
Branch resynced to a clean base with the ACPX line rebuilt from canonical commits. Included:
Validation run:
Head updated: |
|
Correction: previous comment had shell-formatting noise. Status update:
|
|
Closing — this work has been consolidated into #647. All relevant commits were cherry-picked/re-implemented on a clean branch from Thanks for the original work! 🙏 |


Summary
agent-acpxplugin and wire it into the core/cli/web registriespi(codex,claude,gemini)Testing
Notes
This PR is intentionally scoped to the ACPX built-in plugin and its required config/bridge support.