fix: normalize output-axis DoRA with adapted weights - #15458
Draft
orangemagic123 wants to merge 1 commit into
Draft
fix: normalize output-axis DoRA with adapted weights#15458orangemagic123 wants to merge 1 commit into
orangemagic123 wants to merge 1 commit into
Conversation
Contributor
|
✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged. |
Author
|
I have read and agree to the Contributor License Agreement |
Author
|
recheck |
comfy-legal
added a commit
to Comfy-Org/comfy-cla
that referenced
this pull request
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
W + ΔWProblem
weight_decompose()currently builds the adapted weight first:but the output-axis branch calculates its norm from the original base weight:
This applies:
instead of the DoRA decomposition:
The input-axis branch already normalizes
weight_calc, so this change also makes both branches consistent. The behavior now matches the current LyCORIS LoKr/DoRA implementation.Tests
A focused CPU regression harness matching the added assertions passed both cases:
The added repository test can be run with:
The full ComfyUI test suite was not run in the connector environment; GitHub CI is expected to provide repository-level validation.
Related work
This is a separate semantic-correctness fix from the
dora_scalebroadcasting issue tracked in #12938 and PR #13011. The broadcasting fix may touch the same function, but the adapted-weight normalization remains required after that change.