Fix all install warnings, clean up README and gulp files#155
Open
mikemaccana wants to merge 4 commits intoColemanGariety:masterfrom
Open
Fix all install warnings, clean up README and gulp files#155mikemaccana wants to merge 4 commits intoColemanGariety:masterfrom
mikemaccana wants to merge 4 commits intoColemanGariety:masterfrom
Conversation
added 4 commits
July 16, 2018 12:25
warning gulp-jshint > minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue warning gulp-jshint > gulp-util@3.0.8: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5 warning gulp-mocha > gulp-util@2.2.20: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5 warning gulp-mocha > mocha > glob > minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue warning gulp-mocha > mocha > glob > graceful-fs@2.0.3: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js warning gulp-mocha > mocha > jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade warning coffee-script@1.12.7: CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
- Remove comma first (its less popular and hence difficult to read) - Use multi line conditionals (likewise) - Consistent indentation (used 2 spaces as that is most popular) - Fix bug in example where 'done' option was included outside options object - Use ES6 includes instead of bitwise operator - Use ES6 property value shorthands (done) rather than (done: done) - Remove unused code in Gulpfile - Remove extra (actual extra, not ever used by JS) semicolons in Gulpfile
|
Bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dependencies to fix various install warnings
Also clean up README example and Gulpfile for consistent indentation, using ES6, etc.